STEP Import as: hierarchy / flat / union + progress - #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #237
Test plan
docs/usage.mdandCHANGELOG.mdNote
Medium Risk
Changes the STEP import path (threading, cancel, and three Shape List placement modes) where geometry and hierarchy bugs would be user-visible; desktop off-thread OCCT transfer needs correct commit-on-UI-thread discipline.
Overview
STEP import UX is reworked: the Import dialog drops the pre-transfer metadata table and replaces the Union shapes checkbox with Import as (Preserve hierarchy, Flat solids, Union shapes).
Confirming import runs STEP through a new Importing... modal. Desktop runs
prepare_step_importon a background thread withAtomic_progress_indicator(stage, percent, Cancel); WASM shows the modal for two frames then runs transfer on the main thread without Cancel. Document changes happen only viacommit_step_importon the UI thread.Occt_view::import_stepnow takesStep_import_modeand splits work intoprepare_step_import(read/scale/fuse) pluscommit_step_import(hierarchy groups, flat root leaves, or union under current group). XCAF/plain STEP readers forwardMessage_ProgressRangefor cancellable transfer.Reviewed by Cursor Bugbot for commit 2eef05a. Bugbot is set up for automated code reviews on this repo. Configure here.