fix(#558): write Docker Desktop autostart for a provisioned daily user

scripts/install-k8s.ps1

@@ -2124,17 +2124,59 @@ function Set-DailyUserProvisioning {
     }
   } catch { Log "docker-users add failed: $_" }
 
-  # 2) Docker Desktop autostart via the per-user Run key (current user only -- a
-  # different user's hive may not be loaded). The engine also runs as a service
-  # (--always-run-service, #419), so Docker is usable on sign-in regardless.
+  # 2) Docker Desktop autostart. On the WSL2 backend, dockerd runs INSIDE the
+  # docker-desktop distro that the Docker Desktop GUI boots; without the GUI
+  # autostarting on the daily user's login, the engine isn't up after a reboot,
+  # so the k3d containers (which carry --restart unless-stopped) have no daemon
+  # to restart into and the client is down until someone opens Docker Desktop
+  # manually (#558). For the CURRENT user the per-user Run key is simplest. For
+  # a PROVISIONED DIFFERENT user (the hospital IT-installs-elevated case), their
+  # registry hive isn't loaded, so the Run key can't be written for them; drop a
+  # shortcut into THEIR Startup folder instead — the same "launch at this user's
+  # logon" mechanism, no hive needed. --always-run-service (#419) is kept as a
+  # backstop, but its headless-engine behaviour is Docker-Desktop-version
+  # dependent, so autostart is no longer left to it alone for the second user.
   try {
     $ddExe = "$env:ProgramFiles\Docker\Docker\Docker Desktop.exe"
-    if ($user -eq $env:USERNAME -and (Test-Path $ddExe)) {
+    if (-not (Test-Path $ddExe)) {
+      Log "autostart skipped: Docker Desktop not found at $ddExe"
+    } elseif ($user -eq $env:USERNAME) {
       New-ItemProperty -Path 'HKCU:\Software\Microsoft\Windows\CurrentVersion\Run' `
         -Name 'Docker Desktop' -Value "`"$ddExe`"" -PropertyType String -Force -ErrorAction Stop | Out-Null
       $did += "autostart enabled"
+    } else {
+      $profileDir = Get-UserProfileDir -User $user
+      if ($null -eq $profileDir) {
+        # Never signed in -> no profile/Startup folder to write into. Name the
+        # one-click GUI setting they can flip after first sign-in.
+        $did += "no profile for '$user' yet -- have them enable Docker Desktop's 'Start Docker Desktop when you sign in' (Settings > General) after first sign-in"
+      } else {
+        $startupDir = Join-Path $profileDir 'AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup'
+        if (-not (Test-Path $startupDir)) { New-Item -ItemType Directory -Path $startupDir -Force -ErrorAction Stop | Out-Null }
+        $lnkPath = Join-Path $startupDir 'Docker Desktop.lnk'
+        $wsh = New-Object -ComObject WScript.Shell
+        try {
+          $sc = $wsh.CreateShortcut($lnkPath)
+          $sc.TargetPath       = $ddExe
+          $sc.WorkingDirectory = (Split-Path $ddExe)
+          $sc.Save()
+        } finally {
+          [System.Runtime.InteropServices.Marshal]::ReleaseComObject($wsh) | Out-Null
+        }
+        $did += "autostart enabled (Startup shortcut in '$user's profile)"
+      }
     }
-  } catch { Log "autostart set failed: $_" }
+  } catch {
+    # A thrown COM/dir/permission failure here (creating the Startup folder, the
+    # WScript.Shell COM object, or saving the .lnk) must surface in the summary too
+    # -- otherwise docker-users succeeding prints a green "Configured for" with no
+    # autostart note, and IT leaves the elevated window thinking the daily user is
+    # ready while Docker Desktop won't launch on their login and the client is down
+    # after every reboot (#558 Bugbot). Mirror the .wslconfig catch below: log AND
+    # append a manual-step note to $did so the summary is honest about what's left.
+    Log "autostart set failed: $_"
+    $did += "couldn't set Docker Desktop autostart -- have '$user' enable Docker Desktop's 'Start Docker Desktop when you sign in' (Settings > General)"
+  }
 
   # 3) Training-sized .wslconfig in the daily user's profile. Merge the memory
   # budget in without clobbering any other tuning (processors/swap/...), and keep

scripts/manifest.sha256

@@ -15,4 +15,4 @@ e373403d7bb5ce3728b8d21af89e6bf672cc35bbf8938541eb527ae19cb9473b  scripts/lib/as
 911fd0714b17357bb205fc8a8fa8e13eedc1a9632a2f63d4ead9f8d8c7ee546f  scripts/lib/probe.sh
 38761a6c56dc85b3f5742df036e6a2ec2baa0adb0c90b3753b6706779528b7be  scripts/lib/summary.sh
 77e03332ebfab1ef759c6148a57afcf479c02c5dc6cc7b0e0e680f58e20cd364  scripts/lib/diagnose.sh
-35745834c814b03950f6e6a36d3df40fadec51f8f9fe743b6d647a8eedd3679c  scripts/install-k8s.ps1
+350fa54afc491ed353fecae7bbe42ad6c24be8d28915b7aeefdac27626536339  scripts/install-k8s.ps1

scripts/tests/install-k8s.Tests.ps1

@@ -171,6 +171,21 @@ Describe "Daily-user provisioning wiring (#418 source guards)" {
   It "notes .wslconfig as a manual step when the write itself throws (no silent catch)" {
     $script:PSRC | Should -Match "couldn't write .wslconfig"
   }
+  It "autostarts Docker Desktop for a provisioned DIFFERENT user via a Startup-folder shortcut (#558)" {
+    # A different user's hive isn't loaded, so the per-user Run key can't be written
+    # for them; a .lnk in THEIR Startup folder is the hive-free equivalent.
+    $script:PSRC | Should -Match 'CreateShortcut'
+    $script:PSRC | Should -Match 'Start Menu\\Programs\\Startup'
+    $script:PSRC | Should -Match 'autostart enabled \(Startup shortcut'
+  }
+  It "notes autostart as a manual step when the Startup-shortcut path throws (no silent catch) (#558)" {
+    # COM/dir/permission failures in the cross-user autostart path must append a
+    # manual-step note to $did, mirroring the .wslconfig catch -- otherwise
+    # docker-users succeeding prints a green "Configured for" with no autostart note
+    # and IT leaves thinking the daily user is ready while Docker Desktop won't launch.
+    $script:PSRC | Should -Match "couldn't set Docker Desktop autostart"
+    $script:PSRC | Should -Match "Start Docker Desktop when you sign in"
+  }
   It "sanitizes the prompted daily-user name before it hits net localgroup + paths" {
     $script:PSRC | Should -Match '\$other = ConvertTo-SanitizedInput \$other'
   }