Skip to content

fix(mail): guard sendMessage against leaking into production maildir #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tps-flint merged 1 commit into from
May 17, 2026
+12 −0
Merged

fix(mail): guard sendMessage against leaking into production maildir #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/cli/src/utils/mail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,18 @@ export function sendMessage(to: string, body: string, from?: string): MailMessag
assertValidAgentId(sender);
assertValidBody(body);

// Guard: when running in test mode or when the caller has explicitly
// opted in, refuse to write to the default ~/.tps/mail/ directory
// unless TPS_MAIL_DIR is set. This prevents tests from accidentally
// spraying messages into the real production maildir (e.g. when
// imported directly without beforeEach setting TPS_MAIL_DIR to a temp dir).
if ((process.env.NODE_ENV === "test" || process.env.TPS_MAIL_REQUIRE_EXPLICIT_DIR) && !process.env.TPS_MAIL_DIR) {
throw new Error(
"TPS_MAIL_DIR must be set explicitly in test mode. " +
"Refusing to write to the default production maildir.",
);
}

const inbox = getInbox(to);
const quotaCount = countInboxMessages(to);
if (quotaCount >= MAX_INBOX_MESSAGES) {
Expand Down
Loading