Repository navigation
e2e: fix Detox suite drift, run against local Worker + local D1 - #111
Merged
Merged
Conversation
Superset of PR102 + spec fixes; verified green (9/9 files, 22/22 tests) on a fully local stack: wrangler dev (PR97 worker code) + --local D1 + iOS simulator, API_BASE_URL=http://127.0.0.1:8787/api. No --remote, no *.workers.dev, no CLOUDFLARE_* tokens, no D1 REST. - front/e2e/{01..07,_smoke,chatImageUpload}.e2e.js: consolidated specs, ported to PR102 seedHelpers API (authed token-first, tokensManifest {profile,bot}, ensureSubscriptionLevel(level), resetOnboardingFresh (access), ensureBot {params} with explicit default-model wiring). - front/e2e/seedHelpers.js: PR102's local-first version verbatim (d1 via local wrangler; workers.dev REST path untouched/unused). - worker/scripts/seed-local-e2e.sql: PR102's seed + Nova Lite vision row (Bedrock 400s image blocks on text-only Nova Micro; chatImageUpload needs it for the assistant-reply tail). - front/app/botChat.tsx: e2e bundled-asset image branch (simulator-local file:// upload, no picsum remote). - front/app/onboarding/WizardStep.tsx: default export (silences the dev banner covering the onboarding CTA in Detox runs). Local-first spec fixes: 02 resets D1 lockout pre-PIN; 04 settles 15s after its D1 storm (rapid local-exec subprocesses ECONNRESET the next API fetch) and wipes non-review chats (row-0 inbox fixture must beat leftover suite chats); 06 polls the user echo via API (cold first-send can drop the optimistic bubble); 07 taps drawer-item-flashcards when already visible (open drawer covers the menu button). Worker runtime comes from PR #97 until merged; this supersedes #102 (do not merge that PR). Local runbook: cp PR97 worker to /tmp, ALLOW_E2E_FAKE_STREAM=true + .dev.vars there, wrangler dev :8787, migrations + seed --local, Metro with EXPO_PUBLIC_API_BASE_URL, detox -c ios.sim.debug. NOTE: front/e2e d1() resolves wrangler via PATH and uses worker/.wrangler state, so point both at the live /tmp runtime (symlink, gitignored-but-untracked by design).
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 13 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Lint: extend the e2e eslint override to all e2e/*.js (seedHelpers had 17 no-undef errors); turn off expo/no-dynamic-env-var there (computed process.env key dodges babel-preset-expo's expo/virtual/env rewrite under jest); drop unused imports in 01/02/05. Lint: 17 errors -> 0. Review fixes (all triaged VALID except 06:271, proven invalid below): - Django compat: gate D1-only setup (resetPinLockoutState, resetOnboardingFresh/deleteAllChatsD1, ensureSubscriptionLevel) behind isWorkerBase in 01/02/03/04/05/06/07/chatImageUpload. - seedHelpers d1Cloudflare honors CLOUDFLARE_WORKER_API_TOKEN alias. - ensurePin with currentPin now always clears+re-sets (guarantees PIN); 02 passes current PIN + D1-clears unknown leftovers on Worker. - ensureBot PATCHes existing bots with opts.params (rerun drift fix). - tokensManifest fails fast on API_BASE_URL vs EXPO_PUBLIC_API_BASE_URL mismatch (app keys tokens by the Expo base). - 01: delegated-login URL via normalized apiBase() (no //login). - 03: refusal-test timeout 120s -> 180s (poll budget is 150s). - 04: transcript test asserts the actually opened chat, not the Worker-only fractions fixture. - 06: real-path bot gets enable_web_search:true; warm-up turn settles cold-start remounts; quota resets (new resetDailyUsageD1 helper mirroring worker resetDailyUsage, placed post-launch because app boot rewrites the account timezone and any tz flip voids the baseline); same post-launch reset in 03/05/chatImageUpload. - 07: wait for chat screen before backToDrawer in beforeAll. - WizardStep moved app/onboarding -> components/onboarding (out of the route tree), 4 named imports + test updated, default export dropped. - botChat: expo-asset declared in package.json, download error logged. - seed-local-e2e.sql: ON CONFLICT upserts (REPLACE wiped FK state); Nova Lite upserted by model_id (capabilities converge to text+image). 06:271 (require non-empty persisted assistant text after cancel) is proven invalid on Worker: turn.ts persists the assistant row ONLY on full completion; a client abort cancels the handler (3 cancel runs, 0 assistant rows). Replaced with persisted-user-echo poll (strongest deterministic server-side assertion for a cancelled turn). Verified on local stack only (127.0.0.1:8787 wrangler dev + --local D1 + simulator; no live-Cloudflare traffic): _smoke, 01 (4/4), 02 (5/5), 03 (2/2), 04 (2/2), 05 (3/3), 06 (2/2), 07 (2/2), chatImageUpload (1/1) all green; lint 0 errors; tsc clean.
Owner
Author
|
@cubic-dev-ai incremental review |
@tpaulshippy I’ve started reviewing the changes since the last completed review. I’ll post the results here when it’s done. |
There was a problem hiding this comment.
All reported issues were addressed across 22 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…ns, seed default invariant)
- 06 (P1): reset the usage baseline again after the warm-up echo poll
and before the measured prompt — the warm-up alone can push a
level-0-seeded account over the daily cap. No relaunch in between, so
the timezone (and baseline) is stable.
- 04 (P2): transcript preflight normalizes inbox.results || inbox || [],
exactly like beforeAll, so a Django response without a results wrapper
reads as the array instead of an empty inbox.
- 04 (P2): post-navigation proof the transcript rendered assistant
history via stable native surface only — exact API message count in
the subtitle ('Read only · N messages') + mounted transcript list —
alongside the existing unique user strings and API assistant checks
(assistant bubbles are WebView-rendered, never matchable).
- seed-local-e2e.sql (P2): explicit default-model invariant — clear any
old default, set Nova Micro default, force Nova Lite non-default,
all idempotent on reseed. Verified: pre-set Lite default, reseeded
twice, flags converge to Micro=1/Lite=0 and stay.
Verified local-only (127.0.0.1:8787 wrangler dev + --local D1 +
simulator): 06 2/2, 04 2/2 green; node --check + eslint clean on
touched files; full front lint 0 errors.
Owner
Author
|
@cubic-dev-ai incremental review |
@tpaulshippy I’ve started reviewing the changes since the last completed review. I’ll post the results here when it’s done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated local-first E2E: supersedes #102 (its seedHelpers.js is included byte-identical, plus a Nova Lite vision row in the seed SQL).
What changed (13 files):
wrangler d1 execute --local, workers.dev via D1 REST, Django via seed-command hintsLocal runbook (zero Cloudflare traffic):
Terminal 1: copy worker/ aside if needed, add gitignored .dev.vars (JWT_SECRET + AWS/Tavily),
npx wrangler dev --port 8787,d1 migrations apply syft-db --local,d1 execute syft-db --local --file=./scripts/seed-local-e2e.sqlTerminal 2:
API_BASE_URL=http://127.0.0.1:8787/api npx detox test -c ios.sim.debugVerification: full suite 22/22 green in one run on local stack (127.0.0.1:8787 + iPhone 16 Pro sim). No deploys, no live-D1 traffic, no secrets committed.
Summary by cubic
Consolidates the Detox E2E suite to run entirely against a local Worker + local D1, so tests require no live Cloudflare traffic or Django backend. All nine specs now self-seed using shared REST/D1 helpers and verify against the real API.
Key changes
front/e2e/seedHelpers.jswith three-way seeding (localwrangler d1 execute --local, workers.dev REST, and Django seed hints) and ported all specs to it.worker/scripts/seed-local-e2e.sqlseeding the two E2E users and the Nova Lite vision model;ON CONFLICTupserts preserve FK state, and reseeds converge to Nova Micro as default with Nova Lite non-default.botChat.tsxuploads a bundled asset as a simulator-localfile://URI instead of a remote URL, which always failed; addedexpo-assetas a dependency.WizardStep.tsxfromapp/onboarding/tocomponents/onboarding/to get it out of the route tree and stop the dev-warning banner from covering the onboarding CTA.e2e/*.js(fixes 17no-undeferrors) and disabledexpo/no-dynamic-env-varfor computed env reads.isWorkerBasefor Django compatibility.Written for commit 45ced0d. Summary will update on new commits.