Repository navigation
Settings: address sub-tab review feedback - #38
Merged
Merged
Conversation
- Clear consumed drafts on success (create/promote/commit/new-branch) - Render model setup before the status gate so BYOK works while loading - Recompute Delete-branch enablement while typing - Scope branch drafts to the repo via ghResetBranches; track picked branch across switch/new/delete
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
- Compare-and-clear drafts (create/promote/commit/new-branch) so text typed mid-flight survives the in-flight action - Scope branch-draft reset to repo changes (ghNoteLinked/ghSetLinked); same-repo History loads keep picker input; logout clears - Sync picker to refreshed current in new/switch/delete catch paths; drop delete drafts only when the name is actually gone - Test asserts structure: setup-before-gate ordering, handler body, guarded clears
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #37 addressing the 4 cubic P2s:
ghDraftfields.syncDelBtn.ghResetBranchesclears picker/delete drafts (called on open/create/promote/logout); switch/new track the picked branch; delete clears the deleted name.Test: extended
branches.test.tsserved-page needles covering each fix.Summary by cubic
Settings now keep model setup available while GitHub status loads or fails, and clear completed action drafts without losing text typed mid-flight.
Written for commit d65bacf. Summary will update on new commits.