fix: reject multipart ranges before validation#661
Open
shblue21 wants to merge 1 commit intotower-rs:mainfrom
Open
fix: reject multipart ranges before validation#661shblue21 wants to merge 1 commit intotower-rs:mainfrom
shblue21 wants to merge 1 commit intotower-rs:mainfrom
Conversation
Member
I think it would make sense to keep the specific error message body. Can you bring it back? |
Author
|
Thanks. I’ll keep the multipart-specific body so the response stays behavior-preserving. That will require a small |
ca0e6ea to
4448c39
Compare
Author
|
Added the small |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ServeDir/ServeFiledo not support multipart range responses, but they still validate multipartRangeheaders before later rejecting them with416 Range Not Satisfiable.That means requests that are guaranteed to be rejected still pay the cost of
validate(file_size)first. In practice, this includes the pairwise overlap checks done during range validation.Solution
Reject multipart ranges before calling
validate(file_size).This change keeps the fix small by only updating
serve_dir/open_file.rs:validate(file_size)for single-range requestsThis reuses the existing
Err(_) -> 416response path and adds a regression test covering a valid multipart range request.Note: this changes the
416response body for valid multipart range requests fromCannot serve multipart range requeststo empty, since they now fall through the existing genericErr(_) -> 416path infuture.rs.Refs: #660