feat: expose classmethod to build tortoise config

[waketzheng]

Description

1. The init function of tortoise.context.Context is too long
2. Add a new classmethod to TortoiseConfig which is used for sharing config between contexts

Motivation and Context

Base on #2159

This function has too many lines; shorten it.

How Has This Been Tested?

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added the changelog accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codspeed-hq]

Merging this PR will not alter performance

✅ 24 untouched benchmarks

---

_{Comparing waketzheng:feat-typed-config (0cf3b41) with develop (4874995)}

[seladb]

@waketzheng this PR has many changes that are not related to the PR title and description. Maybe you should break them into multiple PRs?

[seladb]

@waketzheng this PR still seems to have unrelated changes. We have this PR to add pre-commit, and this PR for Starlette v1 support. These changes can probably be removed from this PR

[waketzheng]

@waketzheng this PR still seems to have unrelated changes. We have this PR to add pre-commit, and this PR for Starlette v1 support. These changes can probably be removed from this PR

@seladb No need to do that. I expected this PR to be reviewed after the previous one merged, so I explicitly mentioned that it’s based on #2159. Actually, I refactored the code once when fixing mypy complaints after Starlette upgraded, and then separated it into three PRs.

[seladb]

@waketzheng this PR still seems to have unrelated changes. We have this PR to add pre-commit, and this PR for Starlette v1 support. These changes can probably be removed from this PR

@seladb No need to do that. I expected this PR to be reviewed after the previous one merged, so I explicitly mentioned that it’s based on #2159. Actually, I refactored the code once when fixing mypy complaints after Starlette upgraded, and then separated it into three PRs.

@waketzheng is there a reason to open these changes as stacked PRs? It looks like these are separate changes that can each have their own PR based on develop 🤔

[waketzheng]

1. Using stacked PRs avoids merge conflicts
2. I can prek run --all-files to check this PR (prek is a reimagined version of pre-commit, built in Rust.)
3. You can select the latest commit (instead of all commits) to compare the code between this PR and the previous one.

[seladb]

1. Using stacked PRs avoids merge conflicts

Yes, if the changes in the stacked PRs depend on each other, otherwise there shouldn't be merge conflicts. Here it looks like the actual commit related to this PR doesn't depend on the changes in the other PR. What am I missing here? 🤔

[waketzheng]

Yes, if the changes in the stacked PRs depend on each other, otherwise there shouldn't be merge conflicts. Here it looks like the actual commit related to this PR doesn't depend on the changes in the other PR. What am I missing here? 🤔

You forgot that I need the pre-commit config to enforce code style.

[seladb]

You forgot that I need the pre-commit config to enforce code style.

I'm not sure why pre-commit is needed for this PR, but anyway - the pre-commit PR was merged so this PR is simpler now 🙂

[seladb]

Please see one comment, otherwise LGTM

[seladb]

Maybe we can make it a public method instead of private/protected?

[waketzheng]

Maybe we can make it a public method instead of private/protected?

If it to be a public method, should generating config from db_url/modules also be public? For example:

230         else:
231             return cls.generate_config(db_url, modules)
232
233     @classmethod
234     def generate_config(
235         cls, db_url: str, modules: dict[str, Iterable[str | ModuleType]]
236     ) -> TortoiseConfig:
237         from tortoise.backends.base.config_generator import generate_config
238
239         config_dict = generate_config(db_url, app_modules=modules)
240         return cls.from_dict(config_dict)
241
242     @classmethod
243     def get_config_from_config_file(cls, config_file: str) -> TortoiseConfig:

[seladb]

I guess we can add it...