Conversation
What was broken Challenge submission lists could only be filtered by handle, date range, and minimum score, so users with a submission ID from logs had no direct way to find the matching row and submitter. Root cause The submissions section filter state and filter predicate did not include submission identifiers, even though the table displays each submission ID. What was changed Added a Submission ID text filter next to the Handle filter. Matched the filter against current and legacy submission IDs with case-insensitive partial matching before pagination. Any added/updated tests Added a SubmissionsSection test covering filtering by current and legacy submission IDs.
# Conflicts: # src/apps/work/src/pages/challenges/ChallengeEditorPage/components/SubmissionsSection/SubmissionsSection.spec.tsx # src/apps/work/src/pages/challenges/ChallengeEditorPage/components/SubmissionsSection/SubmissionsSection.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Challenge submission lists could only be filtered by handle, date range, and minimum score, so users with a submission ID from logs had no direct way to find the matching row and submitter.
Root cause
The submissions section filter state and filter predicate did not include submission identifiers, even though the table displays each submission ID.
What was changed
Added a Submission ID text filter next to the Handle filter.
Matched the filter against current and legacy submission IDs with case-insensitive partial matching before pagination.
Any added/updated tests
Added a SubmissionsSection test covering filtering by current and legacy submission IDs.
Validation run:
source ~/.nvm/nvm.sh && nvm use && yarn test:no-watch SubmissionsSection --runInBandpassed.source ~/.nvm/nvm.sh && nvm use && yarn lintpassed.source ~/.nvm/nvm.sh && nvm use && yarn run buildpassed with existing webpack/CSS warnings.source ~/.nvm/nvm.sh && nvm use && yarn test:no-watch --runInBand --silent --json --outputFile=/tmp/pm-5511-jest.jsonwas run; it currently fails in unrelated existing suites outside the files changed for PM-5511.