Conversation
…x for performance.
What was broken Marathon Match rerating skipped a challenge whenever the review summation row carried rated=false, even when the completed challenge metadata marked the challenge as rated. Root cause The Marathon Match replay path treated submission-level rating metadata as authoritative before loading the challenge metadata. That allowed stale or backfilled row metadata to suppress the challenge-level rating decision. What was changed Marathon Match rerating now relies on challenge-level rating metadata when deciding whether to include a challenge in the replay history, matching the Development rerating path. Any added/updated tests Added a Marathon Match unit test proving a challenge with rated challenge metadata still writes stats and history when summation rows contain stale rated=false metadata.
PM-5051: Rerate rated Marathon Match challenges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-5016