Conversation
What was broken Private engagements were forced to have at least one active assigned member. After the last assignment was completed or removed, saving the engagement to mark it completed failed because there were no active assignments left. Root cause The engagement service treated privacy as requiring an active assignment during create, update, and assignment-removal flows, even though completed assignments are terminal history and private engagements can still require members without currently assigning one. What was changed Removed the active-assignment requirement for private engagements while keeping the guard that prevents assigning more active members than requiredMemberCount. Updated the assignment-removal documentation to match the new behavior. Kept lint-required formatting fixes produced by the repo lint command. Any added/updated tests Added service tests covering private engagement creation without an assigned member, marking a private engagement closed after all assignments are completed, and removing the final active assignment from a private engagement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Private engagements were forced to have at least one active assigned member. After the last assignment was completed or removed, saving the engagement to mark it completed failed because there were no active assignments left.
Root cause
The engagement service treated privacy as requiring an active assignment during create, update, and assignment-removal flows, even though completed assignments are terminal history and private engagements can still require members without currently assigning one.
What was changed
Removed the active-assignment requirement for private engagements while keeping the guard that prevents assigning more active members than requiredMemberCount. Updated the assignment-removal documentation to match the new behavior. Kept lint-required formatting fixes produced by the repo lint command.
Any added/updated tests
Added service tests covering private engagement creation without an assigned member, marking a private engagement closed after all assignments are completed, and removing the final active assignment from a private engagement.