Conversation
What was broken Anonymous users opening a group-protected challenge details URL could land on the existing not-found/access-denied state instead of being sent through login first. Root cause (if identifiable) The challenge details load treats anonymous group-access failures as a generic failed challenge load, and the UI did not redirect anonymous users when a challenge payload or access error showed group protection. What was changed Added challenge-detail helpers to detect grouped challenge payloads and anonymous group-access failures, then redirect anonymous users to Topcoder login while preserving the original challenge URL. Authenticated users still follow the existing group membership access check. Any added/updated tests Added challenge-detail tests for grouped challenge detection, anonymous access-error detection, and login URL return-path preservation.
What was broken Wipro and Topgear group challenge detail pages rendered an extra Payments section with Wipro payroll and WCP payment terms. Root cause The challenge detail specification component appended a hard-coded Payments article whenever the challenge belonged to the Wipro community group. What was changed Removed the Wipro-only Payments article from the challenge detail specification while keeping the Wipro community detection for existing sidebar behavior. Any added/updated tests Added a challenge detail specification regression test that renders a Wipro group challenge and verifies the payment section copy is absent.
What was broken - The MM submissions tab could collapse back to the capped submissions embedded in challenge details, so authenticated unregistered users saw only submitters from the recent submissions page. - Final MM ranks and scores could render during an open submission phase when raw submission payloads included finalScore values. Root cause (if identifiable) - mapStateToProps rebuilt mmSubmissions from challenge.submissions whenever review summations existed, ignoring the fully paginated MM submissions already fetched into state. - Final result visibility treated any loaded final score or rank as displayable without checking whether submissions were still open. What was changed - Prefer the fully fetched mmSubmissions state before falling back to challenge details data. - Hide MM final ranks and scores while any submission phase is open, and prevent hidden final scores from affecting sort order. Any added/updated tests - Added regression coverage for preserving fully fetched MM submitters when review summations exist. - Added final result visibility coverage for open submission phases.
PM-5496: Force login for grouped challenge details
PM-5495: Remove Wipro payment section from challenge details
PM-5481: Fix MM submissions leaderboard visibility
What was broken Topgear challenge details previously displayed the Wipro payment terms section. The production removal and regression coverage are already present on the current develop base, but the package lint/test command was blocked by a stale unused import in the challenge-detail test suite. Root cause (if identifiable) The payment text came from a hardcoded Wipro challenge-details section. After that section was removed, the nearby challenge-detail container test still imported mapStateToProps even though the test no longer used it. What was changed Removed the unused mapStateToProps import from the challenge-detail container test so the existing PM-5505/Topgear payment regression coverage and full validation commands run cleanly. Any added/updated tests No new tests were needed because develop already includes a focused challenge-detail specification regression test asserting Wipro/Topgear payment terms are not rendered.
PM-5505: Keep Topgear payment validation passing
Performance updates for loading submissions in marathon matches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-5495
https://topcoder.atlassian.net/browse/PM-5505