Conversation
What was broken - The MM submissions tab could collapse back to the capped submissions embedded in challenge details, so authenticated unregistered users saw only submitters from the recent submissions page. - Final MM ranks and scores could render during an open submission phase when raw submission payloads included finalScore values. Root cause (if identifiable) - mapStateToProps rebuilt mmSubmissions from challenge.submissions whenever review summations existed, ignoring the fully paginated MM submissions already fetched into state. - Final result visibility treated any loaded final score or rank as displayable without checking whether submissions were still open. What was changed - Prefer the fully fetched mmSubmissions state before falling back to challenge details data. - Hide MM final ranks and scores while any submission phase is open, and prevent hidden final scores from affecting sort order. Any added/updated tests - Added regression coverage for preserving fully fetched MM submitters when review summations exist. - Added final result visibility coverage for open submission phases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Root cause (if identifiable)
What was changed
Any added/updated tests