Skip to content

PM-5481: Fix MM submissions leaderboard visibility#7228

Merged
jmgasper merged 2 commits into
developfrom
PM-5481
Jul 1, 2026
Merged

PM-5481: Fix MM submissions leaderboard visibility#7228
jmgasper merged 2 commits into
developfrom
PM-5481

Conversation

@jmgasper

@jmgasper jmgasper commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

What was broken

  • The MM submissions tab could collapse back to the capped submissions embedded in challenge details, so authenticated unregistered users saw only submitters from the recent submissions page.
  • Final MM ranks and scores could render during an open submission phase when raw submission payloads included finalScore values.

Root cause (if identifiable)

  • mapStateToProps rebuilt mmSubmissions from challenge.submissions whenever review summations existed, ignoring the fully paginated MM submissions already fetched into state.
  • Final result visibility treated any loaded final score or rank as displayable without checking whether submissions were still open.

What was changed

  • Prefer the fully fetched mmSubmissions state before falling back to challenge details data.
  • Hide MM final ranks and scores while any submission phase is open, and prevent hidden final scores from affecting sort order.

Any added/updated tests

  • Added regression coverage for preserving fully fetched MM submitters when review summations exist.
  • Added final result visibility coverage for open submission phases.

What was broken
- The MM submissions tab could collapse back to the capped submissions embedded in challenge details, so authenticated unregistered users saw only submitters from the recent submissions page.
- Final MM ranks and scores could render during an open submission phase when raw submission payloads included finalScore values.

Root cause (if identifiable)
- mapStateToProps rebuilt mmSubmissions from challenge.submissions whenever review summations existed, ignoring the fully paginated MM submissions already fetched into state.
- Final result visibility treated any loaded final score or rank as displayable without checking whether submissions were still open.

What was changed
- Prefer the fully fetched mmSubmissions state before falling back to challenge details data.
- Hide MM final ranks and scores while any submission phase is open, and prevent hidden final scores from affecting sort order.

Any added/updated tests
- Added regression coverage for preserving fully fetched MM submitters when review summations exist.
- Added final result visibility coverage for open submission phases.
@jmgasper jmgasper requested a review from kkartunov as a code owner July 1, 2026 06:47
@jmgasper jmgasper merged commit 9920066 into develop Jul 1, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant