Conversation
What was broken The My Submissions table displayed a failed test status when legacy Marathon Match review metadata had testStatus set to FAILED, even when scoring finished and the only failures were per-seed timeouts or crashes. Root cause Older scoring metadata could persist completed seed-level failures as a failed test status. The UI trusted that status directly and did not distinguish completed testcase failures from explicit scorer or preflight failures. What was changed Completed seed-level failure metadata now displays as SUCCESS when progress is 100%, all tests completed, per-seed scores exist, and failed counts are seed-level. Explicit skipped, timed-out, and submission-level failures still display as FAILED. Any added/updated tests Added getSubmissionTestProgress coverage for completed seed failures displaying success and explicit scorer failures remaining failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The My Submissions table displayed a failed test status when legacy Marathon Match review metadata had testStatus set to FAILED, even when scoring finished and the only failures were per-seed timeouts or crashes.
Root cause
Older scoring metadata could persist completed seed-level failures as a failed test status. The UI trusted that status directly and did not distinguish completed testcase failures from explicit scorer or preflight failures.
What was changed
Completed seed-level failure metadata now displays as SUCCESS when progress is 100%, all tests completed, per-seed scores exist, and failed counts are seed-level. Explicit skipped, timed-out, and submission-level failures still display as FAILED.
Any added/updated tests
Added getSubmissionTestProgress coverage for completed seed failures displaying success and explicit scorer failures remaining failed.