Skip to content

PM-5319: Restrict submission uploads to local files#7218

Merged
jmgasper merged 1 commit into
developfrom
PM-5319-1
Jun 15, 2026
Merged

PM-5319: Restrict submission uploads to local files#7218
jmgasper merged 1 commit into
developfrom
PM-5319-1

Conversation

@jmgasper

Copy link
Copy Markdown
Collaborator

What was broken

The challenge submission Filestack picker exposed external import sources such as Google Drive, Dropbox, OneDrive, GitHub, and direct URL for standard submissions.

Root cause (if identifiable)

The non-Topgear picker configuration explicitly allowed every Filestack source even though only uploaded files can go through the expected file handling path.

What was changed

Restricted the standard submission picker source list to local file uploads while leaving the existing Topgear URL submission path intact.

Any added/updated tests

Added FilestackFilePicker coverage to assert standard submissions open Filestack with only the local file system source and Topgear URL submissions still populate URL submission data.

Validation

  • npm run jest -- tests/shared/components/SubmissionPage/FilestackFilePicker/index.jsx
  • npm run lint
  • npm test
  • npm run build

What was broken

The challenge submission Filestack picker exposed external import sources such as Google Drive, Dropbox, OneDrive, GitHub, and direct URL for standard submissions.

Root cause (if identifiable)

The non-Topgear picker configuration explicitly allowed every Filestack source even though only uploaded files can go through the expected file handling path.

What was changed

Restricted the standard submission picker source list to local file uploads while leaving the existing Topgear URL submission path intact.

Any added/updated tests

Added FilestackFilePicker coverage to assert standard submissions open Filestack with only the local file system source and Topgear URL submissions still populate URL submission data.
@jmgasper jmgasper requested a review from kkartunov as a code owner June 15, 2026 00:41
@jmgasper jmgasper merged commit 8284140 into develop Jun 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants