Conversation
What was broken Community App grouped Marathon Match submissions could show an example-test review summation as the provisional score when the example score was newer than the real provisional summation. That made CA disagree with Work Manager for members whose earlier submission failed and whose latest submission had separate example, provisional, and system summations. Root cause (if identifiable) buildMmSubmissionData treated every non-final review summation as provisional. Example summations are also non-final, so their aggregate scores could overwrite the real provisional score during submission row aggregation. What was changed Classify example review summations separately and keep them attached to submission history without letting them update provisional or final display scores. Final scores now update only from final summations, while legacy untyped non-final summations still fall back to provisional. Any added/updated tests Added a Marathon Match submission aggregation test covering system, example, and provisional summations on one latest submission, verifying the example score is retained but not displayed as provisional or final.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Community App grouped Marathon Match submissions could show an example-test review summation as the provisional score when the example score was newer than the real provisional summation. That made CA disagree with Work Manager for members whose earlier submission failed and whose latest submission had separate example, provisional, and system summations.
Root cause (if identifiable)
buildMmSubmissionData treated every non-final review summation as provisional. Example summations are also non-final, so their aggregate scores could overwrite the real provisional score during submission row aggregation.
What was changed
Classify example review summations separately and keep them attached to submission history without letting them update provisional or final display scores. Final scores now update only from final summations, while legacy untyped non-final summations still fall back to provisional.
Any added/updated tests
Added a Marathon Match submission aggregation test covering system, example, and provisional summations on one latest submission, verifying the example score is retained but not displayed as provisional or final.