Conversation
What was broken The non-Marathon Match Submissions tab rendered only the submissions embedded in the challenge details payload. That embedded list can be capped to the first page, so participants disappeared from the visible card as newer submissions arrived. Root cause The complete paginated v6 submissions loader already existed, but the non-MM Submissions tab never used it. What was changed The non-MM, non-design Submissions tab now fetches every v6 submissions page, enriches those rows with registrant and score data, and uses the complete list for grouping and sorting while preserving the embedded list as a fallback. Any added/updated tests Added Submissions helper tests covering enrichment of fetched submissions outside the embedded first page and score population from review summations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The non-Marathon Match Submissions tab rendered only the submissions embedded in the challenge details payload. That embedded list can be capped to the first page, so participants disappeared from the visible card as newer submissions arrived.
Root cause
The complete paginated v6 submissions loader already existed, but the non-MM Submissions tab never used it.
What was changed
The non-MM, non-design Submissions tab now fetches every v6 submissions page, enriches those rows with registrant and score data, and uses the complete list for grouping and sorting while preserving the embedded list as a fallback.
Any added/updated tests
Added Submissions helper tests covering enrichment of fetched submissions outside the embedded first page and score population from review summations.