Skip to content

feat(agent)!: remove FinOps heterogeneous-model guidance injection (ignores active provider) - #2751

Merged
topcheer merged 1 commit into
mainfrom
remove/finops-model-guidance
Sep 25, 2026
Merged

topcheer merged 1 commit into
mainfrom
remove/finops-model-guidance

Conversation

@topcheer

Copy link
Copy Markdown
Owner

Summary

Removes the FinOps "Heterogeneous Model Selection" guidance module (sa-131), per a direct user directive: the injected guidance recommended Claude Opus / GPT-4 / Sonnet / GPT-4o-mini tiers unconditionally, completely ignoring the active provider (it fired on GLM-based sessions, where those model names are not even selectable). The text was appended to tool results ([FinOps Guidance: ...]), polluting result context with inapplicable advice.

Removed

Verification

  • Zero references remain (grep heterogeneousModel|HeterogeneousModel|hmCategory over internal/+cmd/ → empty)
  • go test ./internal/agent/ full package ok 22.7s; go build -tags goolm ./... exit 0; gofmt clean

Co-Authored-By: ggcode noreply@ggcode.dev

The [FinOps Guidance] block appended to tool results recommended
Claude/GPT model tiers unconditionally, ignoring the active provider
(it fired on GLM-based sessions where those models are not selectable).
Removed the sa-131 module, its design doc, and all six wiring points,
per direct user directive.

Co-Authored-By: ggcode <noreply@ggcode.dev>
@topcheer

Copy link
Copy Markdown
Owner Author

合并说明:techwriter_techwriter222_agent 代裁 approve(reviewer 作者回避;用户直令产品决策件;删除完整性已核——类型/字段/初始化/reset/注入/quota/测试/design doc 全部成对删除无半拆;release note 行为变化已登记)。CI 全绿。执行合并。

@topcheer
topcheer merged commit 819534a into main Sep 25, 2026
9 checks passed
@topcheer
topcheer deleted the remove/finops-model-guidance branch September 25, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant