-
Notifications
You must be signed in to change notification settings - Fork 0
String Compression #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tom4649
wants to merge
2
commits into
main
Choose a base branch
from
443.String-Compression
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−0
Open
String Compression #131
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # 443.String-Compression | ||
|
|
||
| ## step1 | ||
| 数字が二桁になる場合を考えなかったがそれ以外にはつまらずに書けた。11mほど。 | ||
|
|
||
| 時間計算量:O(N)、空間計算量 ~~O(1)~~ O(log n): str(count) のメモリ確保のため | ||
|
|
||
| ## step2 | ||
|
|
||
| https://leetcode.com/problems/string-compression/solutions/3245804/clean-codes-full-explanation-two-pointer-e4o9/ | ||
|
|
||
| while文を使った解法。この方が「数字の数を数える」という直感には合っているかもしれない。 | ||
|
|
||
| mediumの割には簡単な問題なように感じた。他の言語だと書き方が難しくなるのかもしれない。 | ||
|
|
||
| ## step3 | ||
| 今回は省略で良いだろう |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| class Solution: | ||
| def compress(self, chars: list[str]) -> int: | ||
| length = 0 | ||
| left = 0 | ||
| for right in range(len(chars) + 1): | ||
| if right < len(chars) and chars[left] == chars[right]: | ||
| continue | ||
| chars[length] = chars[left] | ||
| length += 1 | ||
| if right - left > 1: | ||
| for c in str(right - left): | ||
| chars[length] = c | ||
| length += 1 | ||
| left = right | ||
|
|
||
| return length | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| class Solution: | ||
| def compress(self, chars: list[str]) -> int: | ||
| length = 0 | ||
| index = 0 | ||
|
|
||
| while index < len(chars): | ||
| c = chars[index] | ||
| count = 0 | ||
| while index < len(chars) and chars[index] == c: | ||
| index += 1 | ||
| count += 1 | ||
| chars[length] = c | ||
| length += 1 | ||
| if count > 1: | ||
| for digit in str(count): | ||
| chars[length] = digit | ||
| length += 1 | ||
|
|
||
| return length |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| class Solution: | ||
| def compress(self, chars: list[str]) -> int: | ||
| def append_count(length_before, count): | ||
| length_after = length_before | ||
| while count > 0: | ||
| chars[length_after] = str(count % 10) | ||
| count //= 10 | ||
| length_after += 1 | ||
|
|
||
| left = length_before | ||
| right = length_after - 1 | ||
| while left < right: | ||
| chars[left], chars[right] = chars[right], chars[left] | ||
| left += 1 | ||
| right -= 1 | ||
|
|
||
| return length_after | ||
|
|
||
| length = 0 | ||
| index = 0 | ||
|
|
||
| while index < len(chars): | ||
| c = chars[index] | ||
| count = 0 | ||
| while index < len(chars) and chars[index] == c: | ||
| index += 1 | ||
| count += 1 | ||
| chars[length] = c | ||
| length += 1 | ||
| if count > 1: | ||
| length = append_count(length, count) | ||
|
|
||
| return length |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
str(right - left) で、O(log chars.length) の文字数のメモリが確保されると思うのですが、それが constant extra space と言えるのかどうか気になりました。かりに str をしようしないとしたら、どのようなロジックにすればよいでしょうか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご指摘の通りで、count の桁数分 O(log chars.length) の空間計算量になりますね。自力で気付けませんでした。以下の関数を定義することで constant extra space になるかと思います。