Repository navigation
chore(agents): add review checks and a review skill - #108
Merged
scottlovegrove merged 2 commits intoNov 5, 2026
Merged
scottlovegrove merged 2 commits into
scottlovegrove merged 2 commits into
Conversation
doistbot
reviewed
Nov 5, 2026
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR adds six review checks, a review-changes skill, and a review:worktree script for giving reviewers isolated copies of a change. Few things worth tightening:
- The list-output check says ids go after the name, but existing list commands print the id first (
workspace.ts,channel/list.ts,channel/members.ts) — either update those commands or reword the check as a new-rule-for-new-output convention. - Exclude the destination worktree from the untracked-file copy (capture untracked paths before creating the worktree, or filter it out), since a destination inside the checkout currently aborts setup.
- Disable textconv when generating the patch (
--no-textconv) so configured drivers (e.g. for PNGs) don't produce patchesgit applycan't reproduce; a test would pin this. - Fix paths that will fail the
instructions.test.tsbroken-reference check:skills/comms-cli/SKILL.mdandoauth/client-metadata.jsoninsecurity.mdresolve relative to.agents/checks/— add them toROOTEDor write them repo-root-relative. - Also worth addressing: untracked files go to reviewers and LLM providers unmasked before the privacy check runs, so secrets/PII (
.env, logs, real user fixtures) can leak — filter or exclude them before any review step.
I also included a few optional follow-up notes in the details below.
Optional follow-up notes (5)
.agents/checks/privacy.md:16: Alan Grant and Ellie Sattler aren't cli-core fixtures; they're defined in this repo's
src/lib/__fixtures__/accounts.ts. Point reviewers at the local fixtures so the "Fine" list doesn't send them looking in the wrong package..agents/scripts/lib/review-worktree.ts:47: The cleanup path ignores the result of
git worktree remove --forceand then unconditionallyrmSyncs the target. If removal fails (for example, a locked worktree), the files are still deleted while the repository keeps its worktree registration, leaving stale metadata and breaking the "retry is not refused" guarantee in the comment. Check the result and skiprmSync(or surface the removal failure) when removal did not succeed..agents/scripts/lib/review-worktree.test.ts:98: The test name promises a checkout whose path contains a space, but the test never establishes that
repo.dirhas a space; it depends oncreateTempRepo's hardcoded'agent tools-'prefix. If that prefix changes, the test silently stops covering the scenario it describes. Add an explicitexpect(repo.dir).toContain(' ')(or build the temp repo under a path with a space).docs/agents.md:87: The blast-radius trigger is now restated in
review-changes/SKILL.md, here indocs/agents.md, and in.agents/checks/evidence.md, with different details: only the skill includesargv handlinginsrc/index.tsand build/CI config. Reviewers reading different documents will apply different criteria, and the lists will drift. Point to the skill as the single definition, or make the three lists match..agents/scripts/lib/review-worktree.test.ts:86: The skip guard only covers root. On Windows,
chmodSync(path, 0o000)drops the write bit but the file stays readable, socreateReviewWorktreesucceeds and this test fails with no error thrown. Extend the condition toprocess.getuid?.() === 0 || process.platform === 'win32'(and mention Windows in the comment) so the test skips where it can't run rather than failing.
scottlovegrove
force-pushed
the
scottlovegrove/agents-4-review
branch
from
November 5, 2026 11:22
c456861 to
74fe46a
Compare
scottlovegrove
force-pushed
the
scottlovegrove/agents-4-review
branch
from
November 5, 2026 11:27
74fe46a to
c2e0de1
Compare
Adds six review checks in .agents/checks/: tests, architecture, security, privacy, command surface and evidence. Each says what to report and what is fine. AGENTS.md links them, so Doistbot applies them to pull request reviews too. The security check covers private channels, and the architecture check the batch helpers in src/lib/api.ts. The review-changes skill runs, in parallel, a task review (a fresh agent that gets the owner's request, never the author's reasoning), a blast-radius review when shared code changed, and Doistbot or one agent per check without it. Every finding is fixed, dismissed with evidence, or left open for the owner. npm run review:worktree -- <dir> gives a reviewer its own copy of the change, so the shared checkout stays untouched.
…h textconv createReviewWorktree reads the diff and the untracked files before the worktree exists, so a target inside the checkout is no longer copied into itself, and diffs with --no-textconv, so a configured textconv driver can't produce hunks git apply rejects. The reviewer brief names the untracked files explicitly, since git diff leaves them out, and review-changes asks for every untracked file to be checked for credentials and personal data before any review runs. The architecture and review rules no longer mention batch helpers that no code has, and the command surface check no longer asks for names before ids in lists, which the existing list commands don't do.
scottlovegrove
force-pushed
the
scottlovegrove/agents-4-review
branch
from
November 5, 2026 11:53
c2e0de1 to
b9b4b22
Compare
Contributor
|
🎉 This PR is included in version 3.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Part 4 of 5. Adds review checks and a
review-changesskill for when you say a change is ready.What was changed
.agents/checks/: tests, architecture, security, privacy, command surface, evidence. Each says what to report and what is fine.AGENTS.mdlinks them, so Doistbot applies them too.--include-private-channels.review-changesruns, in parallel:src/lib/,src/index.ts, the cli-core or SDK version);npm run review:worktree -- <dir>gives a reviewer its own copy of the change, so the shared checkout stays untouched. It works with a target inside the checkout and ignores textconv drivers.Please check
Proof
npm run review:worktreerun, removed cleanly afterwards.Not verified
review-changes: the skill needs Doistbot 1.0.12 or newer, and the version I have is older, so it falls back to per-check subagents.