Repository navigation
fix(bigquery): correct percentile and distinct-array transpilation - #8674
Merged
Merged
Conversation
georgesittas
requested review from
tobymao
and
a balanced review from Copilot
October 19, 2026 09:48
Contributor
SQLGlot Integration Test Results✅ All tests passedComparing:
Overallmain: 182931 total, 166014 passed (pass rate: 90.8%) sqlglot:fix/bigquery-aggregate-semantics: 178869 total, 162709 passed (pass rate: 91.0%) Transitions: Dialect pair changes: 0 previous results not found, 1 current results not found ✅ All tests passed |
geooo109
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to d17c768.
APPROX_PERCENTILEas (value, weight, percentile), preserving Presto’s accuracy overload.NULL-removal behavior when foldingARRAY_DISTINCTintoARRAY_AGG, including all-NULLand empty inputs.Verified with runsql against Trino, Presto, DuckDB, and BigQuery.