Repository navigation
fix(parser): parse IS/ISNULL/NOTNULL with lower precedence than comparison - #8668
Closed
ansh-rohilla wants to merge 1 commit into
Closed
ansh-rohilla wants to merge 1 commit into
ansh-rohilla wants to merge 1 commit into
Conversation
ansh-rohilla
force-pushed
the
fix/postgres-operator-precedence-8661
branch
from
October 17, 2026 12:57
d26b6cb to
bf601af
Compare
Collaborator
|
Thanks, but the core team will take a look at this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In standard SQL and PostgreSQL operator precedence, comparison operators (
=,!=,<>,<,>,<=,>=) have higher precedence thanIS,IS NOT,ISNULL, andNOTNULL.Previously in SQLGlot,
ISwas registered inRANGE_PARSERSunder_parse_range(), which sits underneath_parse_comparison()and_parse_equality(). Consequently, in an expression liket.a = t.b IS NULL,t.b IS NULLwas evaluated first as the right-hand operand of=.This PR introduces
_parse_is_predicate()in the parser between conjunctions (AND) and equality/comparison (_parse_equality()), and removesISfromRANGE_PARSERS.Closes #8661