Repository navigation
Add scope-quick and ship-quick for the review-fix loop - #7
Merged
Merged
Conversation
…fixes A blocked ship review had one recommended path: a full scope run, then a full ship run to re-check the fixes. Both are far heavier than fixing a few findings needs. scope-quick writes minimal change sets from the latest review's Blockers, or from a small request, with no interview, argued decisions or subagents, looping the existing lint-spec.py. ship-quick re-ships with one validation run and one reviewer that checks the previous findings and the diff since the last review, then updates the pull request and follows it to green - no gauntlet, panel or fix loop. ship's review report now records the reviewed head commit so a quick run can diff from it, and ship and build recommend the quick loop for plain defects. Bumps the dev plugin to 3.8.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After
buildandship, a blocked review had one recommended path: run the fullscopeagain, then the fullshipto re-check the fixes.Both are far heavier than fixing a few findings needs.
This adds two minimal skills to the
devplugin and pointsshipandbuildat them for plain defects.scope-quick: turns the Blockers of the latestshipreview, or a small request, into change sets inspec.mdforbuild. No interview, no argued decisions, no subagents, no ledger work or HTML. It loops the existinglint-spec.pyand stops with a pointer toscopewhen a finding needs a decision or scope change.ship-quick: one validation run at the diff's impact, one read-only reviewer, then a PR update followed to green. The reviewer marks each previous finding fixed or still open and reads only the diff since the last review for new blockers. No gauntlet, no lens panel, no fix loop.Changes to existing behaviour
ship's review report records the reviewed head commit on itsBase:line, so a quick run can diff from it. Older reviews have no head, so the firstship-quickafter one reads the whole branch diff.shipandbuildrecommendscope-quick,build,ship-quickfor plain defects;scopestays the path for findings that need a decision.plan-layout.mdlists the new writers ofspec.md,review_N.mdandpr.md.devplugin and the Pi package go from 3.7.0 to 3.8.0.plugins/, and a comprehension eval file per skill cover the new skills. The opencode permission block also gains the missingscope-reviewandreflectentries.Testing
scripts/validate.shpasses locally.scope-quickprescribes lints clean, and so does a change set appended after built ones.🤖 Generated with Claude Code