Repository navigation
Scope: name expected echoes, make scope-review optional, remove Jira sync - #6
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
What: four more lint-spec tests for check_echoes. Why: mutation testing showed the wrong-kind echo and the change-plan link branches unproven.
…changes scope's closing hand-off named scope-review first, which read as a required step before build. build never needed a review, so the hand-off now recommends build and mentions scope-review only when the change is large or complex, leaving the choice to the user. The README describes scope-review as optional to match.
The skills carried an opt-in Jira mirror through acli: Epic and Task creation in scope, transitions in build, and an Epic key prefix on ship's branch and PR title. The workflow no longer assumes any issue tracker, so the sections, the jira.md reference, its evals and stub fixture, and the docs that described it are removed. build keeps its work-branch rule under its own heading, and .dev/config.json stays for the run journal opt-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope runs wrote echoes like
D-x (✓ short label)from memory and the firstlint-spec.pypass rejected dozens of them, because the text after the check mark must be copied from the chosen line.The lint error now names what the echo should be, and
scope's echo sentence tells authors to lead each chosen line with the label they will echo.Found by
/dev:reflectthreadscope-echo-lint-mismatchin two runs across two repositories.Plan
.dev/scope-echo-lint-mismatch| Review 1: CONCERNSAlso in this PR
scopenow recommendsbuildas the default next step and mentionsscope-reviewonly when the change is large or complex, leaving that choice to the user.buildnever required a review; only the closing line ofscoperead that way.acliis gone from thedevskills and thefactoryphase copies - thescopeandbuildsections, the Epic key prefix onship's branch and PR title, thejira.mdreference, its evals and stub fixture, and the docs describing it.buildkeeps its work-branch rule under its own heading, and.dev/config.jsonstays for the run journal opt-out.Evidence
Same spec fixture (chosen line
S3 bucket - durable across redeploys, echoed as(✓ cloud storage)), run through the linter at the merge base and on this branch.On merge base
On this branch
Quality
resolution[1:]then.strip())CI parity (impacted, package
.):scripts/validate.shgreen at full; deferred to CI: none; remote-only: macOS and Linux x Python 3.10 and 3.13 matrix.Review panel: spec-conformance, correctness, tests, simplify; 0 blockers, 6 concerns (
.dev/scope-echo-lint-mismatch/review_1.md).Open calls
<text copied from: ...>placeholder, unlike the spec's quoted Error format (review concern, minor).lint()helper.hintis built eagerly then overwritten in two branches (simplify).🤖 Generated with Claude Code