Conversation
… works again CI exports CARGO_TERM_COLOR=always, so rustc diagnostics carry ANSI escape prefixes and the warnings recipe's anchored '^warning:' grep never matches: a warning-bearing tree passed the gate. Strip the escapes with a sed that embeds the ESC via a bash $'…' literal (BSD and GNU sed both accept it) before matching. Verified end to end: with a planted unused variable the old recipe exited 0; after the fix it exits 1 and shows the warning, with and without colors.
Owner
|
Landed on main as b81b15a. Thanks — CI's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
just warningsis the preflight that fails a build when rustc emits warnings. Our CI exportsCARGO_TERM_COLOR=always, which makes rustc prefix every diagnostic with ANSI escapes — and therecipe's anchored
^warning:grep then never matches, so a warning-bearing tree passed the gatesilently. (Reproduced in our CI run before this fix.)
Fix
Strip the escape sequences before matching:
The ESC is embedded as a bash
$'…'literal so both BSD (macOS) and GNU sed accept it.Verification
(reproducing the miss); post-fix it exits 1 and prints the warning.