Fix menu popover collapsing on macOS 26 and sluggish drag-to-reorder - #35
Open
CamilleGuillory wants to merge 1 commit into
Open
Fix menu popover collapsing on macOS 26 and sluggish drag-to-reorder#35CamilleGuillory wants to merge 1 commit into
CamilleGuillory wants to merge 1 commit into
Conversation
On macOS 26 a ScrollView reports a 0 ideal height, so the plain maxHeight frame on the device-list ScrollView let the fit-to-content MenuBarExtra window collapse to just its header and footer — no devices were visible. Size the window to its content (fixedSize vertically) with a maxHeight cap so a long list scrolls instead of collapsing or running off-screen. Also make drag-to-reorder trigger as soon as the dragged row crosses a neighbour's midpoint, instead of needing a ~1.5-row overshoot before the move registered.
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bug fixes
1. Popover collapses to header + footer on macOS 26 (Tahoe)
On macOS 26 a
ScrollViewreports a0ideal height, so themaxHeighton the ScrollView clamps the fit-to-contentMenuBarExtrawindow down to just the header and footer — the device list is invisible.Fix: drop the
maxHeightfrom the ScrollView and size the outerVStackto its content instead, capping the window height so a long list scrolls rather than running off-screen:2. Drag-to-reorder trigger requires overshooting
calculateTargethad a dead-zone plus an off-by-one that meant you had to drag ~1.5 rows before a reorder registered — dragging a row squarely over its neighbour did nothing.Fix: flip as soon as the dragged centre crosses a neighbour's midpoint (
(offset / pitch).rounded()), with a+1for downward inserts.Testing
Built and run on macOS 26. The device list renders at full height and scrolls when long; dragging a row over the adjacent one reorders immediately.