[pull] master from talkiq:master - #393
Merged
Merged
Conversation
#1122) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
python-rsa was archived by its maintainer on 2025-04-20 and is read-only, so it will not receive future fixes, including security ones. `Blob.get_pem_signature` was the only usage. `cryptography` is already installed transitively via `gcloud-aio-auth` (pyjwt RS256), and its `load_pem_private_key` reads both PKCS#1 and PKCS#8 keys directly. That removes the sole reason for the `pyasn1` machinery here: `rsa`'s `load_pkcs1` only takes PKCS#1 DER, while GCP service account keys are PKCS#8 PEM, so we had to unwrap them by hand. PKCS#1 v1.5 is deterministic, so signatures are byte-identical to the previous implementation for both key formats, and malformed or non-RSA keys raise the same ValueError. The IAM signBlob path is unaffected. Also adds the first credential-free unit coverage of this path, which was previously only exercised by the credentialed integration test. N.B. the mypy-storage hook pinned gcloud-aio-auth==5.4.4, which caps cryptography at < 49 and conflicts with the pin used elsewhere in the config; bumped to 5.5.0 to match the repo.
* Remove users no longer in this organization from CODEOWNERS file * chore: rename @cphoward -> @caseydialpad in CODEOWNERS --------- Co-authored-by: Kevin James <KevinJames@thekev.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )