fix(providers): drop the redundant FromStr import that a newer stable denies - #7
Conversation
… denies `src/providers/test.rs` imported `std::str::FromStr as _` alongside `use super::*`. The glob already brings it in — `use` items are private but visible to a child module, and `src/providers/mod.rs:15` imports `FromStr` for its own `impl FromStr for ProviderKind` — so the second import has always been redundant. Rust 1.98 reports it, `-D warnings` denies it, and the `Rust` job fails to compile the lib test. `ProviderKind::from_str` still resolves through the glob, so every call in this file is unchanged. This is not a regression in any branch. `main` carries the same line and last ran CI on 2026-08-18, when `stable` did not report it; the toolchain moved underneath it. Any PR opened since then fails on it — PR tinyhumansai#4 is the one that surfaced it, on a file it does not touch. Fixing it here rather than in that PR keeps the blame legible and unblocks every other branch at the same time. Verified on three toolchains, matching the three CI lanes: - 1.98.0 (nearest local stable): `cargo clippy --all-targets --all-features -- -D warnings` clean, `cargo test --all-features` and `cargo test` both 155 pass, `cargo build --all-targets --all-features` clean. - 1.88 (the declared MSRV, `rust-version` in Cargo.toml): `cargo build --all-targets --all-features` clean — the glob resolves the trait there too, so removing the import does not cost MSRV support. - `cargo fmt --all -- --check` clean.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe provider test module removes a redundant ChangesProvider test cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized cleanup removes a redundant import without changing production behavior, and no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
How this change flows0 changed behaviours across 11 relationships. 5 surrounding behaviours are shown (39 graph nodes walked). 15 further behaviours left out to keep the diagram readable. flowchart LR
n0["Vercel"]:::impacted
n1["lookup"]:::impacted
n2["credentials_from"]:::impacted
n3["...sing_key_names_every_variable_it_searched"]:::impacted
n4["the_prefixed_variable_wins"]:::impacted
n2 -->|calls| n1
n3 -->|uses| n0
n3 -->|calls| n1
n3 -->|tests| n1
n3 -->|calls| n2
n3 -->|tests| n2
n4 -->|uses| n0
n4 -->|calls| n1
n4 -->|tests| n1
n4 -->|calls| n2
n4 -->|tests| n2
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Green: changed behaviour. Grey: surrounding behaviour. Arrows name the call, use, implementation, or test relationship. Orange: has findings. Red: has a finding that blocks the merge. |
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
@senamakel — this needs a maintainer to merge; I only have It is one line, and it is what is holding your #4 red. Worth stressing: this is not #4's doing. Green on all five lanes here, including Once it lands, a re-run of #4 should clear that lane with no change to your commits. |
2 participants
What this is
One import.
src/providers/test.rs:6haduse std::str::FromStr as _;sitting next touse super::*, and the glob already bringsFromStrin —useitems are private but visible to a child module, andsrc/providers/mod.rs:15imports it forimpl FromStr for ProviderKind. The second import has always been redundant.Rust 1.98 started reporting it,
-D warningsdenies it, and theRustjob fails to compile the lib test:ProviderKind::from_strstill resolves through the glob, so the three call sites in that file are untouched.This is a main-branch breakage, not a PR's
Worth being explicit, because the symptom points at the wrong place.
maincarries this line and last ran CI on 2026-08-18, green —stabledid not report it then.stablemoved. Every branch opened since fails on it.#4 is where it showed up, on a file that PR does not touch. Fixing it on
mainrather than inside #4 keeps that legible and unblocks every other branch at once — #4 should go green on its next run once this lands.Verification
Three toolchains, matching the three CI lanes:
Rustcargo clippy --all-targets --all-features -- -D warnings(1.98.0)Rustcargo test --all-featuresandcargo test(1.98.0)Rustcargo build --all-targets --all-features(1.98.0)Minimum supported Rust versioncargo build --all-targets --all-features(1.88, the declaredrust-version)cargo fmt --all -- --checkThe MSRV check is the one that mattered: the glob resolves the trait on 1.88 too, so dropping the import costs no MSRV support.
I left a comment in place of the import so the next person does not re-add it.
Summary by CodeRabbit