-
Notifications
You must be signed in to change notification settings - Fork 15
refactor: take the tool vocabulary from tinytools #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
997df3f
f444d94
25bf74b
b741690
b9b6045
744020a
5c003c6
86bfc91
73689c4
aa4678b
5ceb81e
8d036da
1393dcf
10c74db
d6122ff
190a881
c010172
0cc56de
d0e0226
954b3dc
2332573
67ca1c7
b34ae75
785c27c
ad33569
1c7a62e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,8 @@ jobs: | |
| - uses: actions/checkout@v7 | ||
| with: | ||
| fetch-depth: 0 | ||
| # Required to resolve the `vendor/tinytools` path dependency. | ||
|
senamakel marked this conversation as resolved.
|
||
| submodules: recursive | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🟠 Major | 🏗️ Heavy lift 🔎 Supported by static analysis🏁 Script executed: printf '%s\n' '--- repository knowledge scopes ---'
find /tmp/coderabbit-repo-knowledge/tinyhumansai-tinyagents-e004d811 -maxdepth 2 -type f -name '*.md' -print | sort
printf '%s\n' '--- release workflow ---'
cat -n .github/workflows/release.yml
printf '%s\n' '--- related checkout/push patterns ---'
rg -n -C 3 'actions/checkout|persist-credentials|git push|cargo' .github/workflowsRepository: tinyhumansai/tinyagents Length of output: 11325 🏁 Script executed: cat /tmp/coderabbit-repo-knowledge/tinyhumansai-tinyagents-e004d811/conventions/repo-wide.md
printf '%s\n' '--- CI checkout contract ---'
cat -n .github/workflows/ci.yml | sed -n '15,30p'
printf '%s\n' '--- release workflow security-relevant range ---'
cat -n .github/workflows/release.yml | sed -n '19,53p;101,132p'Repository: tinyhumansai/tinyagents Length of output: 4428 🌐 Web query:
💡 Result: In actions/checkout v7, the persist-credentials input defaults to true [1][2]. When enabled, this setting configures the authentication token (or SSH key) in the local git configuration of the checked-out repository [1][3]. This allows your workflow scripts to perform authenticated Git commands, such as pushing changes or fetching submodules, without additional manual setup [1][2]. Key points regarding this behavior include: * Mechanism: The action modifies the local git configuration to include the necessary credentials [1][3]. To enhance security in recent versions, credentials are persisted to a separate file (e.g., using includeIf) to avoid exposing them directly in standard configuration locations [4][5]. * Cleanup: The action performs a post-job cleanup step to remove these credentials, ensuring they do not persist after the workflow job completes [1][2]. * Security Considerations: If you do not require authenticated git operations within your workflow, you can opt out of this behavior by setting persist-credentials to false [1][2]. * Documentation: The official README for actions/checkout v7 confirms that persist-credentials is true by default and that it is used to configure tokens or SSH keys in the local git config [1][2]. Citations:
Disable checkout credentials before running repository code. 🧰 Tools🪛 zizmor (1.29.0)[warning] 31-35: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) 🤖 Prompt for AI AgentsSources: MCP tools, Linters/SAST tools
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Real finding, but declining it in this PR — flagging rather than silently ignoring, and I would support it as its own change. The concern is accurate: Two reasons it does not belong here:
Doing that blind, in a PR about tool-type vocabulary, trades a theoretical token exposure for a real chance of a broken release. It deserves its own PR where the token wiring can actually be exercised. Leaving this thread open rather than resolving it, so it stays visible as accepted-but-deferred instead of disappearing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I will keep the thread open. Would you like me to create a GitHub follow-up issue for the credential isolation change? 🐇 You are interacting with an AI system. |
||
|
|
||
| - uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| [submodule "wiki"] | ||
| path = wiki | ||
| url = https://github.com/tinyhumansai/tinyagents.wiki.git | ||
| [submodule "vendor/tinytools"] | ||
|
senamakel marked this conversation as resolved.
senamakel marked this conversation as resolved.
|
||
| path = vendor/tinytools | ||
| url = https://github.com/tinyhumansai/tinytools.git | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.