docs(readme): state the Rust version the toolchain actually pins - #5792
docs(readme): state the Rust version the toolchain actually pins#5792ntdatt812 wants to merge 1 commit into
Conversation
All six READMEs told contributors to install Rust 1.93.0. rust-toolchain.toml pins 1.96.1, and its own comment says why: rusqlite 0.40 / libsqlite3-sys 0.38 use `cfg_select!`, stabilized in 1.96. Following the README therefore produced a build failure in those crates on the very first `cargo check`. CONTRIBUTING.md already stated 1.96.1, so the two documents disagreed with each other as well as with the pin. Closes tinyhumansai#5781
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe contributor instructions in the English, German, Japanese, Korean, Urdu, and Chinese READMEs now require Rust 1.96.1 instead of Rust 1.93.0. ChangesRust prerequisite documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized documentation-only change aligns contributor instructions with the repository's pinned Rust toolchain, with no actionable merge-blocking risk remaining after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.) Warning Your free Security trial is over. An organization admin can activate billing to continue. Comment |
Closes #5781.
The defect
All six READMEs told contributors to install Rust 1.93.0. The pin says otherwise, and its own comment says why:
CONTRIBUTING.md:41already stated1.96.1, so the two contributor-facing documents disagreed with each other as well as with the pin. A new contributor following the README hit acfg_select!build failure inlibsqlite3-syson their firstcargo check— before writing a line of code.Verified in-tree
The change
Six files, one substitution each, nothing else touched — the surrounding prose and every translation are unchanged.
grep -rc '1\.93\.0'over the six files returns nothing afterwards.Summary by CodeRabbit