docs: fix Rust version 1.93.0 → 1.96.1 in all 6 READMEs (Fixes #5781) - #5789
docs: fix Rust version 1.93.0 → 1.96.1 in all 6 READMEs (Fixes #5781)#5789yunaremaia wants to merge 1 commit into
Conversation
…mansai#5781) README and all 5 translations instructed contributors to install Rust 1.93.0, but rust-toolchain.toml pins 1.96.1 because rusqlite 0.40 / libsqlite3-sys 0.38 require cfg_select! (stabilized in 1.96, rust-lang/rust#115585). Following the README's instructions with 1.93.0 causes build failures. Update all 6 README files to 1.96.1 to match rust-toolchain.toml and CONTRIBUTING.md. Signed-off-by: Yunare Maia <yunare@gmail.com>
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
tinysweeper
Bot
added
the
priority: p3
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe six English and translated README files now require Rust 1.96.1 instead of Rust 1.93.0 in contributor setup instructions. Other required tools remain unchanged. ChangesContributor prerequisite documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates documentation to match the repository’s configured Rust version without changing product or runtime behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.) Warning Your free Security trial is over. An organization admin can activate billing to continue. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef68c87d43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| New contributor? Start with [`CONTRIBUTING.md`](./CONTRIBUTING.md) for the fork/PR workflow and local validation commands, or use the copy-paste AI-agent prompt in [`CONTRIBUTING-BEGINNERS.md`](./CONTRIBUTING-BEGINNERS.md#optional--let-an-ai-coding-agent-guide-you). The short path is: | ||
|
|
||
| 1. Install Git, Node.js 24+, pnpm 10.10.0, Rust 1.93.0 (`rustfmt` + `clippy`), CMake, Ninja, ripgrep, and the platform desktop build prerequisites. | ||
| 1. Install Git, Node.js 24+, pnpm 10.10.0, Rust 1.96.1 (`rustfmt` + `clippy`), CMake, Ninja, ripgrep, and the platform desktop build prerequisites. |
There was a problem hiding this comment.
When readers follow the “Getting Set Up” link from this same section, gitbooks/developing/getting-set-up.md still tells them to install Rust 1.93.0 (:22, :31-32, :44-45), and gitbooks/developing/building-rust-core.md still says the pinned channel is 1.93.0. Because those public contributor docs remain one click from the updated README and contradict rust-toolchain.toml, contributors following the longer setup path can still end up with the toolchain this change is trying to avoid; include the linked setup docs in this bump.
AGENTS.md reference: AGENTS.md:L16-L16
Useful? React with 👍 / 👎.
1 participant
Fixes #5781
Problem
rust-toolchain.tomlpinschannel = "1.96.1"becauserusqlite 0.40/libsqlite3-sys 0.38requirecfg_select!(stabilized in 1.96, rust-lang/rust#115585).CONTRIBUTING.mdalready says1.96.1, but all 6 READMEs (README.md + 5 translations) still say1.93.0. Following the README causes build failures.Solution
Update all 6 files to
1.96.1:Verified:
grep -rn "1.96" README.md docs/README*.mdshows 6/6 updated, matchesrust-toolchain.tomlandCONTRIBUTING.md.Note:
CONTRIBUTING-BEGINNERS.mdandDockerfilealso reference1.93.0— left out of scope per issue acceptance criteria, happy to follow up if desired.Summary by CodeRabbit