Skip to content

chore(vendor): bump tinycortex — corroboration gate for bare credit-card runs - #5605

Merged
senamakel merged 1 commit into
tinyhumansai:mainfrom
YellowSnnowmann:chore/bump-tinycortex-cc-corroboration
Aug 20, 2026
Merged

chore(vendor): bump tinycortex — corroboration gate for bare credit-card runs#5605
senamakel merged 1 commit into
tinyhumansai:mainfrom
YellowSnnowmann:chore/bump-tinycortex-cc-corroboration

Conversation

@YellowSnnowmann

@YellowSnnowmann YellowSnnowmann commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Pulls tinyhumansai/tinycortex#154 (plus the four tinycortex main commits between the current pin 8401346 and its base): the memory-store PII scrubber no longer redacts a bare 13-19 digit run on Luhn alone — a ~10% false-positive rate on arbitrary digit runs, which was rewriting Luhn-valid 13-digit epoch-millisecond timestamps inside serialized memory envelopes into [REDACTED_PII_CREDIT_CARD] and corrupting the JSON.

Downstream symptom: tinyhumansai/opencompany#1201 — the embedded namespace memory driver's conformance lane red on ~36% of runs, presenting as the driver losing writes (the read side silently dropped every corrupted record).

Bare runs now need a real network IIN at an issued length or a card keyword within 32 bytes; separated runs (4111 1111 1111 1111) keep the Luhn-only gate they always had. Bare card dumps like 4111111111111111 still redact.

Chain

Verification

tinycortex at the pinned SHA: full lib suite 1260 + 132 passed, fmt + clippy clean. opencompany's previously-flaky store::memory conformance suite reproduced the corruption 100% deterministically on the old pin (pinned Luhn-valid timestamp) and passes on this one — evidence in opencompany#1201.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated an internal component to a newer reviewed revision.
    • This maintenance update improves internal consistency and keeps the application aligned with the current reviewed baseline.
    • No user-facing features, behavior changes, interface updates, or workflow changes are included.
    • Existing functionality remains unchanged for end-users.
    • The update does not alter exported capabilities or visible application behavior.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f0f7bea8-0359-46b9-87b1-ac262b5e53c3

📥 Commits

Reviewing files that changed from the base of the PR and between a29c424 and 7a91af3.

📒 Files selected for processing (1)
  • vendor/tinycortex

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The vendor/tinycortex submodule reference advances to commit bfd2ea2127f32b53f5f925354855b9ed3a5887ab, which contains the linked credit-card redaction fix.

Changes

Tinycortex vendor update

Layer / File(s) Summary
Update tinycortex reference
vendor/tinycortex
The submodule pointer updates to commit bfd2ea2127f32b53f5f925354855b9ed3a5887ab.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: 🔵 Low · up to 7a91a

This update changes credit-card detection and timestamp handling in the vendored dependency; an incorrect pin or incomplete validation could leave memory records corrupted. The change is otherwise localized and mergeable with owner awareness that the target revision and its formatting, lint, and test checks must be confirmed.

Suggested reviewers: senamakel, tinysweeper

Poem

A rabbit follows one pointer line,
Tinycortex updates fine.
Bare timestamps keep their shape,
Card checks now escape the scrape.
Hop through the vendor gate—
Records stay intact and straight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the tinycortex vendor bump and its bare credit-card corroboration purpose.
Linked Issues check ✅ Passed The vendored revision includes the bare-run corroboration fix and preserves required card and timestamp behavior for [#154].
Out of Scope Changes check ✅ Passed The PR changes only the tinycortex submodule reference, which directly supports the linked issue objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Aug 20, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 20, 2026
@YellowSnnowmann
YellowSnnowmann marked this pull request as ready for review August 20, 2026 09:05
@YellowSnnowmann
YellowSnnowmann requested a review from a team August 20, 2026 09:05

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out · 19 embedded · openrouter/openai/text-embedding-3-small

coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 20, 2026
@YellowSnnowmann
YellowSnnowmann force-pushed the chore/bump-tinycortex-cc-corroboration branch from 1632f00 to a29c424 Compare August 20, 2026 09:36
@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Aug 20, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 20, 2026
@YellowSnnowmann
YellowSnnowmann force-pushed the chore/bump-tinycortex-cc-corroboration branch from a29c424 to 590899a Compare August 20, 2026 10:18
…ard runs

Pulls tinyhumansai/tinycortex#154: the PII scrubber no longer redacts a
bare 13-19 digit run on Luhn alone (a ~10% false-positive rate on
arbitrary digit runs). Bare runs now need a real network IIN at an
issued length or a card keyword nearby; separated runs keep the
Luhn-only gate. Root fix for tinyhumansai/opencompany#1201, where
Luhn-valid 13-digit `at_millis` stamps were redacted out of stored
memory envelopes, corrupting the JSON and presenting as the embedded
namespace driver losing writes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@senamakel
senamakel merged commit 92bab8d into tinyhumansai:main Aug 20, 2026
26 checks passed
oxoxDev pushed a commit to tinyhumansai/opencompany that referenced this pull request Aug 20, 2026
…valid digit runs

Advances vendor/openhuman to tinyhumansai/openhuman#5605 (openhuman main
v0.63.13 + the vendor/tinycortex bump to tinyhumansai/tinycortex#154).

tinycortex's PII scrubber redacted any bare 13-19 digit run that passed
Luhn — ~10% of arbitrary runs — which rewrote Luhn-valid 13-digit
`at_millis` values inside this repo's serialized memory envelopes to
`[REDACTED_PII_CREDIT_CARD]`, corrupting the JSON. The embedded
namespace driver then dropped every corrupted record on read, which is
what #1201 observed as the driver losing writes (~36% of conformance
runs red). Bare runs now require a real network IIN at an issued length
or a card keyword nearby; separated runs keep the Luhn-only gate.

Also adds the [patch] entry this bump exposes the need for: since
tinycortex@8401346 (tinymemory#18 §A1, already on openhuman main),
tinycortex-api depends on tinymemory-api by git URL. [patch.crates-io]
does not redirect git sources, so without a
[patch."https://github.com/tinyhumansai/tinymemory"] section the git
checkout joins the graph beside the vendored path copy and every shared
contract type becomes two types — tinymemory-core stops compiling.
openhuman carries exactly this entry for itself; replicated here with
the path rebased onto the vendored checkout, same as the existing WS4
entries.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants