Repository navigation
Support branches in the db commands and in service get and delete - #270
Open
nathanjcochran wants to merge 1 commit into
Open
nathanjcochran wants to merge 1 commit into
nathanjcochran wants to merge 1 commit into
Conversation
nathanjcochran
added this pull request to stack #273
October 21, 2026 22:07
nathanjcochran
changed the title
nathanjcochran
marked this pull request as ready for review
October 21, 2026 22:20
nathanjcochran
force-pushed
the
nathan/branches-2-existing-commands
branch
from
October 22, 2026 20:20
5fd3edc to
385e0b0
Compare
… and delete The db commands now resolve their ref through the API's resolve endpoint, so behind the experimental gate they accept a branch, by ID or name, as well as a service or read replica set. Their help mentions branches behind the gate, a paused or unready branch is reported as a branch, and db psql's password recovery resets a branch's password through the branch endpoint. service get shows a fluid service's branch count behind the gate. service delete lists the branches deleted along with a fluid service, before its confirmation prompt and after the delete. That listing isn't gated, since the API deletes the branches either way.
nathanjcochran
force-pushed
the
nathan/branches-2-existing-commands
branch
from
October 22, 2026 21:41
385e0b0 to
9677ea6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates existing commands for branches.
dbcommands now resolve their ref through the API's resolve endpoint instead of the ref filter on the service list. BehindTIGER_EXPERIMENTAL, that lets them take a branch, by ID or name, as well as a service or read replica set, and their help says so.tiger branchcommands.db psqlskips its read-replica menu for a branch, and its password recovery resets a branch's password through the branch endpoint.service getshows a fluid service's branch count behind the gate (branch_countin JSON/YAML). If counting fails, it prints a warning and leaves the count out.service deletelists the branches deleted along with a fluid service, before the confirmation prompt and after the delete. This isn't gated, since the API deletes the branches either way. Only the help text mentions branches behind the gate.Changes to existing behavior:
dbcommands now depend on the resolve endpoint, which isn't deployed yet, so this can't be released before the API ships it.dbmessages. "Not found" now reads "service or read replica set '…' not found". A read replica set that isn't active reads as "not ready" rather than "paused". Under discussion; likely to be reverted to the old behavior.The
tiger servicecommands keep the service-list lookup, which is the only way to reach a read replica set by ID today. They can move to the resolve endpoint once replica sets have their own commands (TODO onresolveService).