Repository navigation
Prepare connection and password helpers for branches, and tidy up output - #268
Open
nathanjcochran wants to merge 1 commit into
Open
nathanjcochran wants to merge 1 commit into
nathanjcochran wants to merge 1 commit into
Conversation
…tidy up output Sync openapi.yaml and regenerate the API client. Connections now go through a ConnectionTarget built from what connecting needs (endpoint, status, environment tag, credential owner) rather than a pair of api.Service values, and passwords are stored against a PasswordTarget. A read replica set is no longer dressed up as a service. Also: - Empty lists print [] in json/yaml; their table-case messages go to stderr. - output*Table functions take their writer first. - No port is guessed for an endpoint without one. - The password update endpoints accept only a 204.
nathanjcochran
added this pull request to stack #273
October 21, 2026 22:07
nathanjcochran
changed the title
nathanjcochran
marked this pull request as ready for review
October 21, 2026 22:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for branch support, which the PRs stacked on this one add, plus a few unrelated cleanups. Apart from the cleanups listed below, nothing user-facing changes.
openapi.yamlis synced from the Tiger Cloud API spec and the client is regenerated. This brings in the branch endpoints and the resolve endpoint, which nothing uses yet.ConnectionTargetheld twoapi.Servicevalues: the one to connect to, and the one whose credentials to use. A read replica set had to be dressed up as a service to fit. It now holds just what connecting needs (kind, ID, name, status, environment tag, endpoint, pooler) and aCredentialOwner, with a constructor per kind.GetConnectionDetailstakes a target, andCheckServiceReadybecameCheckReady, which takes a status.SavePasswordWithResult, andGetPasswordtake aPasswordTarget(project ID, ID, and endpoint) instead of anapi.Service. The keyring key format is unchanged. The password reset helpers take aCredentialOwner.User-facing cleanups:
service listandservice backup listprint[]for an empty list with-o json/yaml, instead of nothing. Empty-result messages appear only in table output, on stderr. This also applies toservice backup region listandservice metrics series.tiger service get/listor the MCP service detail. pgpass storage, which keys entries by host and port, refuses such an endpoint rather than assuming 5432.The
output*Tablefunctions now take their writer first, and the service output functions take an options struct.