Repository navigation
Switch from fatih/color to charmbracelet/lipgloss - #259
Open
nathanjcochran wants to merge 2 commits into
Open
nathanjcochran wants to merge 2 commits into
nathanjcochran wants to merge 2 commits into
Conversation
fatih/color to charmbracelet/lipgloss
nathanjcochran
marked this pull request as ready for review
October 9, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces fatih/color with charmbracelet/lipgloss for colored output. Lipgloss is more capable and more widely used, it integrates with the BubbleTea UIs we already use, and it doesn't rely on mutable global state like
color.NoColor.Color handling now lives in the output streams rather than in individual commands. The root command wraps stdout and stderr in writers that strip or downsample ANSI sequences to suit the terminal, so commands render styles unconditionally, and
--color=false(orcolor: falsein the config) turns color off for both streams in one place.This also fixes some color bugs.
fatih/coloronly checks whether stdout is a terminal, and the per-command overrides that worked around this for stderr also ignored the user's environment (NO_COLOR,TERM=dumb) and could leak escape codes into redirected output. Now each stream checks its own terminal, and the user's environment is respected, includingNO_COLOR,CLICOLOR_FORCE, andTERM=dumb.tiger db psqlhands psql the underlying file descriptors, so psql still sees a real terminal. Output sticks to the base ANSI colors, which follow the user's terminal theme.