minor fixes & improvements - #19
Open
Camper-CoolDie wants to merge 10 commits into
Open
Conversation
Contributor
Author
|
В Secrets.json остались старые ссылки на сервера, утром пофикшу |
Fixes: BON-244
Closes: BON-107
Fixes: BON-255
Closes: BON-251
Closes: BON-256
Fixes: BON-257
Fixes: BON-258
timas130
requested changes
May 17, 2026
Comment on lines
14
to
20
| val currentDayOfWeek: Int | ||
| get() { | ||
| var i = GregorianCalendar.getInstance().get(Calendar.DAY_OF_WEEK) - 2 | ||
| if (i == -1) i = 6 | ||
| return i | ||
| // Idk how this works | ||
| var day = Calendar.getInstance().get(Calendar.DAY_OF_WEEK) - 2 | ||
| if (day == -1) day = 6 | ||
| return day | ||
| } |
Owner
There was a problem hiding this comment.
Calendar.DAY_OF_WEEK всё ещё начинается с единицы, которая обозначает воскресенье. [1] По-хорошему надо в ControllerUpdater.kt, где он используется, заменить 0 на Calendar.MONDAY (если такова была задумка)
Owner
There was a problem hiding this comment.
Вообще стоило оставить какое-нибудь ограничение типа один пост на юзера.
|
|
||
| object ControllerModeration { | ||
| fun parseComment(comment: String, userId: Long = 0L): String { | ||
| val comment = comment.trim() |
Owner
There was a problem hiding this comment.
Suggested change
| val comment = comment.trim() | |
| comment = comment.trim() |
Comment on lines
-25
to
+30
| const val S3_ROOT = "https://proxy.bonfire.moe/bonfire" | ||
| const val MELIOR_ROOT = "https://proxy.bonfire.moe/api" | ||
| const val SERV_ROOT = "https://proxy.bonfire.moe/cf2" | ||
| lateinit var SERV_ROOT: String | ||
| lateinit var MELIOR_ROOT: String | ||
| lateinit var S3_ROOT: String | ||
| const val TL_ROOT = "https://proxy.bonfire.moe" | ||
|
|
||
| const val DOMEN = "https://bonfire.moe/r/" | ||
| lateinit var DOMEN: String |
Owner
There was a problem hiding this comment.
Вообще можно было бы сделать BuildConfig и в CampfireApi, local.properties же единый. Просто чтобы не играть с огнём с lateinit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gradle.properties. Их можно будетуказать в
local.properties. ВSecrets.jsonпоявилось новое полеapiappIdнужен в случае, если был задан другой айди приложения в консоли Firebase (дляgoogle-services.json)README.mdпоявилось краткое описание банкикоторые содержат только пробелы) (BON-191)
Вт, 02.12.2025 22:56:39) (BON-256)02 дек.->2 дек.)