Skip to content

*: downgrade log-level of some noisy logs - #440

Open
LykxSassinator wants to merge 3 commits into
tikv:8.10.tikvfrom
LykxSassinator:downgrade_log_level
Open

*: downgrade log-level of some noisy logs#440
LykxSassinator wants to merge 3 commits into
tikv:8.10.tikvfrom
LykxSassinator:downgrade_log_level

Conversation

@LykxSassinator

@LykxSassinator LykxSassinator commented Aug 19, 2026

Copy link
Copy Markdown

Description

close #439

Downgrade the log-level of noisy logs when calling PrefetchTail.

Summary by CodeRabbit

  • Bug Fixes
    • Reduced the visibility of routine tail prefetch size messages by logging them at debug level instead of warning level.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot Bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2026
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@LykxSassinator, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e599bef9-1aec-46fc-a924-39b8fabb5a33

📥 Commits

Reviewing files that changed from the base of the PR and between d359069 and af09df3.

📒 Files selected for processing (1)
  • table/block_based/block_based_table_reader.cc

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e29c471e-7a95-4b2d-bcaa-a0b546fdd73b

📥 Commits

Reviewing files that changed from the base of the PR and between 52b6fe1 and d359069.

📒 Files selected for processing (1)
  • table/block_based/block_based_table_reader.cc
🚧 Files skipped from review as they are similar to previous changes (1)
  • table/block_based/block_based_table_reader.cc

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

BlockBasedTable::PrefetchTail now emits heuristic and statistics-derived tail prefetch messages at debug level. Prefetch sizing and control flow remain unchanged.

Changes

Tail prefetch logging

Layer / File(s) Summary
Adjust tail prefetch log levels
table/block_based/block_based_table_reader.cc
The two tail prefetch diagnostic messages change from warning logs to debug logs.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d3590

This is a narrowly scoped log-level adjustment with no actionable merge-blocking risk remaining; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR demotes noisy logs but does not add the required Statistics tickers for tail prefetch size sources [#439]. Add and increment the manifest, statistics, and heuristics tail prefetch Statistics tickers in PrefetchTail().
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary change: lowering the log level for noisy messages.
Out of Scope Changes check ✅ Passed The reported change is limited to log-level updates in PrefetchTail() and is within the linked issue scope [#439].
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhangjinpeng87 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BlockBasedTable::PrefetchTail Warning Message Spams the RocksDB logs

1 participant