Skip to content

Support of update in tables without updated column#12

Open
LionelLaffineur wants to merge 1 commit intotigron:masterfrom
LionelLaffineur:master
Open

Support of update in tables without updated column#12
LionelLaffineur wants to merge 1 commit intotigron:masterfrom
LionelLaffineur:master

Conversation

@LionelLaffineur
Copy link
Copy Markdown
Contributor

No description provided.

@gerryd
Copy link
Copy Markdown
Member

gerryd commented Apr 21, 2026

At the very least I would move $updated_field = self::trait_get_table_field_updated(); outside of the if() and check against that instead of calling it twice.

But I am also curious why you are falling into this if() in the first place; what does is_dirty() do if you pass it null? And should it allow passing null in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants