Restore protect-builtin-tiers.yaml#4941
Open
pasanw wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The operator doesn't carry Calico's admission policies by hand — at release time a script wipes its
pkg/imports/admission/calico/directory and re-copies everything fromapi/admission/in whatever Calico version the release pins. Whenrelease-v1.43was cut, it pinned the Calicov3.32.0tag, but that tag predates a Calico commit that movedprotect-builtin-tiers.yamlintoapi/admission/(it still lived at the oldapi/config/admission/path back then), so the re-copy found nothing and silently dropped the file. With the manifest gone, the operator rendered zero ValidatingAdmissionPolicies for Calico instead of the expected two — which broke the build, since the operator's tests assert that those two policies get created. This fix restores that one manifest into the operator's import directory, bringingrelease-v1.43back in line with what master already ships and re-arming the guardrail that blocks deletion of the built-in tiers.Release Note
🤖 Generated with Claude Code