[v3.24] feat(gatewayapi): bump bundled Envoy Gateway helm chart to v1.8.0#4934
Open
electricjesus wants to merge 1 commit into
Open
[v3.24] feat(gatewayapi): bump bundled Envoy Gateway helm chart to v1.8.0#4934electricjesus wants to merge 1 commit into
electricjesus wants to merge 1 commit into
Conversation
Re-derived onto current master after tigera#4690 (Namespaced Mode) rewrote the gatewayapi renderer to render the embedded helm chart at runtime (the prior static gateway_api_resources.yaml is gone). - Makefile: ENVOY_GATEWAY_VERSION v1.7.2 -> v1.8.0 - go.mod: github.com/envoyproxy/gateway v1.7.2 -> v1.8.0, cascading sigs.k8s.io/gateway-api v1.4.1 -> v1.5.1. controller-runtime stays at master's v0.24.1; go mod tidy confirms the v0.24.1 + gateway-api v1.5.1 + gateway v1.8.0 set resolves. - pkg/render/gatewayapi/gateway-helm.tgz: regenerated from upstream gateway-helm v1.8.0. - gateway_api.go: parseManifest now handles the two new admission-policy kinds the v1.8 chart ships (ValidatingAdmissionPolicy + ValidatingAdmissionPolicyBinding for the gateway-api "safe-upgrades" policy). Without this, the renderer's fail-loud default trips on them. - gateway_api_test.go: controllerExpected gains the safe-upgrades VAP + binding. v1.8.0 adds ListenerSet support, requested by community users for cert-manager / external-dns integration on Gateway-API installs (tigera#4534). (cherry picked from commit a7ecd98)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #4832 onto
release-v1.43(Calico Enterprise v3.24).Description
Brings the Envoy Gateway v1.8.0 bundled-chart bump to the v3.24 operator branch. Cherry-picks cleanly —
release-v1.43already carries the #4690 (Namespaced Mode) renderer, same as master, so the EG-1.8.0 delta applies with no conflict.Type: enhancement.
Makefile:ENVOY_GATEWAY_VERSION v1.7.2 → v1.8.0. release-v1.43 already pinsGO_BUILD_VER=1.26.3-llvm21.1.8-k8s1.36.1, so noGOTOOLCHAINworkaround is needed.go.mod:github.com/envoyproxy/gateway v1.7.2 → v1.8.0, cascadingsigs.k8s.io/gateway-api v1.4.1 → v1.5.1(controller-runtime stays at v0.24.1).pkg/render/gatewayapi/gateway_api.go:parseManifesthandles the two new admission-policy kinds the v1.8 chart ships —ValidatingAdmissionPolicy+ValidatingAdmissionPolicyBinding(gateway-apisafe-upgrades).gateway_api_test.go:controllerExpectedgains them.See #4832 for full rationale + the upstream v1.8.0 behavior-change list.
Verification
go mod tidyclean on the release-v1.43 base —controller-runtime v0.24.1+gateway-api v1.5.1+gateway v1.8.0resolve.go test ./pkg/render/gatewayapi/...— pass (embedded chart regenerated at v1.8.0 via helm v3.20.2).Release Note
For PR author
gateway_api_test.goupdated for the new admission-policy resources.make gen-files— N/A (no pkg/apis changes).make gen-versions— N/A (EG chart version, not a CE component version).For PR reviewers
kind/enhancement,enterprise,release-note-required,docs-pr-required.