test(render): resolve calico image dynamically in goldmane/whisker deployment tests#4932
Merged
caseydavenport merged 1 commit intoJun 16, 2026
Conversation
…ployment tests The Goldmane and Whisker deployment render tests hardcoded the expected combined calico image as quay.io/calico/calico:master. The renderer resolves it via components.GetReference(CombinedCalicoImage(...)), which tracks the pinned ComponentCalico version. On master the pin is "master" so the tests passed by coincidence; on release branches (e.g. release-v1.43 pinning v3.32.0) the hardcoded ":master" no longer matches the rendered ":v3.32.0", failing the full-Deployment Equal. Compute the expected image the same way the renderer does, so the tests are version-agnostic and pass on every branch and across pin bumps.
3 tasks
caseydavenport
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Goldmane and Whisker deployment render tests hardcoded the expected
combined calico image as
quay.io/calico/calico:master(and the whiskercontainer image as
quay.io/calico/whisker:master). The renderer resolvesthese via
components.GetReference(components.CombinedCalicoImage(...))andcomponents.GetReference(components.ComponentCalicoWhisker), which track thepinned component versions.
On master the pins are
master, so the tests pass by coincidence. On releasebranches (e.g.
release-v1.43, which pins calicov3.32.0) the rendered imageis
:v3.32.0while the test expects:master, so the full-DeploymentEqualassertion fails.
This computes the expected images the same way the renderer does, making the
tests version-agnostic so they pass on every branch and survive pin bumps.
pkg/render/goldmane,pkg/render/whiskergo test ./pkg/render/goldmane/ ./pkg/render/whisker/passes on bothmasterandrelease-v1.43.Release Note
For PR author
make gen-filesmake gen-versions