Remove the deprecated Compliance feature#4924
Draft
caseydavenport wants to merge 4 commits into
Draft
Conversation
Delete the Compliance CRD and its API types, the compliance controller, the compliance rendering, and the compliance-benchmarker image. Drop the compliance integration from the manager controller (license check, watch, Voltron compliance env vars) and the now-dead compliance network-policy rules in guardian, dex and linseed. Keep the compliance data API - LogStorage retention fields and Tenant data types - since Linseed still serves historical compliance data. Regenerated deepcopy.
Drop the Compliance CR test cases and the compliance config plumbing from the manager and manager-controller tests, and the compliance override entries from the components test. Also discard the now-unused license value in the manager controller (the fetch stays for its not-found validation).
Drop ComponentComplianceBenchmarker from the gen-versions template so the generated enterprise.go matches. Remove the compliance rules from the rendered network-policy golden files (dex, manager, guardian, linseed) and drop tigera-compliance from the DNS / node-local-DNS namespace selectors. Adjust the manager non-cluster-host egress count now that the compliance egress rule is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the deprecated Compliance feature from the operator. Deletes the
ComplianceCRD and its API types, the compliance controller, the compliance rendering, and thecompliance-benchmarkerimage, and drops the compliance integration from the manager controller (license check, watch, Voltron compliance env vars) along with the now-dead compliance network-policy rules in guardian, dex and linseed.The compliance data API is kept - the
LogStorageretention fields andTenantdata types - since historical compliance data is still served from storage.