fix(gatewayapi): split envoy-gateway NetworkPolicy ingress by IP family#4894
Closed
electricjesus wants to merge 1 commit into
Closed
fix(gatewayapi): split envoy-gateway NetworkPolicy ingress by IP family#4894electricjesus wants to merge 1 commit into
electricjesus wants to merge 1 commit into
Conversation
The calico-system.envoy-gateway ingress allow put both 0.0.0.0/0 and ::/0 in
a single rule's Source.Nets, which Calico rejects ("rule contains both IPv4
and IPv6 CIDRs") — the whole NetworkPolicy fails to apply and the gatewayapi
reconcile aborts before rendering the rest. Split the allow-from-anywhere into
two rules, one per address family (dual-stack and IPv6-only both need ::/0).
4 tasks
Member
Author
|
Superseded by #4887 (identical NP ingress split, merged). Closing as dupe — test coverage for the per-family split to follow separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix. The
calico-system.envoy-gatewayNetworkPolicy ingress allow put both0.0.0.0/0and::/0in a single rule'sSource.Nets, which Calico rejects ("rule contains both IPv4 and IPv6 CIDRs"), so the policy fails to apply on dual-stack and IPv6 clusters. Split the allow into one rule per address family.Split out of #4821 — standalone fix, no WAF dependency.
Tested:
go test ./pkg/render/gatewayapi/...— asserts the ingress is rendered as two per-family rules.Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
release-note-requireddocs-not-required