istio: grant waypoint controller namespaced secret-write via RoleBinding#4877
Draft
alexh-tigera wants to merge 1 commit into
Draft
istio: grant waypoint controller namespaced secret-write via RoleBinding#4877alexh-tigera wants to merge 1 commit into
alexh-tigera wants to merge 1 commit into
Conversation
The waypoint pull-secrets controller copies the Installation pull secret into namespaces that contain istio-waypoint Gateways so waypoint pods can pull the Istio proxy image from a private registry. The operator's cluster-wide secrets grant is read-only, so CopyToNamespace is RBAC-denied in a user namespace. Render a per-namespace tigera-operator-secrets RoleBinding in each waypoint namespace (ordered before the copied secrets, cleaned up after them so write access persists while the secrets are removed), mirroring how egressgateway obtains namespaced secret-write. Unit tests (fake client) and GKE node-cred environments masked this gap. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The waypoint pull-secrets controller copies the Installation pull secret into namespaces that contain istio-waypoint Gateways so waypoint pods can pull the Istio proxy image from a private registry. The operator's cluster-wide secrets grant is read-only, so CopyToNamespace is RBAC-denied in a user namespace.
Render a per-namespace tigera-operator-secrets RoleBinding in each waypoint namespace (ordered before the copied secrets, cleaned up after them so write access persists while the secrets are removed), mirroring how egressgateway obtains namespaced secret-write. Unit tests (fake client) and GKE node-cred environments masked this gap.
Description
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.