feat(error): implement core::error::Error for error types#674
Merged
Conversation
ytakano
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref(#204)
implementing core::error::Error for error types across awkernel_drivers and awkernel_lib.
For error types that already had a
fmt::Displayimplementation, onlyimpl core::error::Error for T {}was added:PCIeDeviceErrIxgbeDriverErrIgbDriverErrVfsIoErrorFor error types that had no
Displayimplementation, aDisplayimpl delegating toDebugviawrite!(f, "{self:?}")was added alongsidecore::error::Error:VirtioDriverErrNvmeDriverErrMiiErrorRtcErrorUartErrorDeviceTreeErrorFrameBufferErrorNetManagerErrorNetDevErrorStorageDevErrorThe following error types remain unaddressed and are left for a follow-up:
IgcDriverErrGenetErrorStorageManagerErrorVfsErrorKindInMemoryDiskErrorInitErrVtdErrorMapErrorDmaErrorRecvErr,SendErrDagErrorTcpSocketErrorUdpSocketErrorRelated links
How was this PR tested?
Notes for reviewers