Fix ETS missing value handling - #449
Merged
Merged
Conversation
mitchelloharawild
requested changes
Sep 8, 2026
mitchelloharawild
left a comment
mitchelloharawild
left a comment
Member
There was a problem hiding this comment.
Looks good, minor issue with the unit tests.
Comment on lines
+174
to
+175
| expect_no_error(UK_missing |> model(ETS(mdeaths))) | ||
| fit_missing <- UK_missing |> model(ETS(mdeaths)) | ||
| expect_no_error(fit_missing) |
Member
There was a problem hiding this comment.
The later will not correctly catch errors. testthat emits the result value invisibly from expect_*() functions which can assign fit_missing.
Suggested change
| expect_no_error(UK_missing |> model(ETS(mdeaths))) | |
| fit_missing <- UK_missing |> model(ETS(mdeaths)) | |
| expect_no_error(fit_missing) | |
| fit_missing <- expect_no_error(UK_missing |> model(ETS(mdeaths))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
tests/testthat/test-ets.Rupdated and passing🤖 Generated with Claude Code