Repository navigation
fix(v2): surface toasts via RPC TUI companion - #395
Merged
Merged
Conversation
Server plugins under OpenCode v2 have no ui.toast, so showToast fell through to a console-only stub. Emit toast intents over rpc.register and render them from a new ./tui companion that OpenCode auto-loads. Refs: tickernelz#391
2 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui.toast, soclient.tui.showToastwas stubbed to a console-only fallback ({ data: false }) — see v2: toasts silently dropped — server plugins have no client.tui (please add a TUI companion) #391.MemToastRPC contract on the server and emit toast intents from the legacy client bridge../tuicompanion that subscribes to those events and callsctx.ui.toast.show.Test plan
bun test tests/v2-legacy-client.test.ts tests/tui-companion.test.ts tests/plugin-v2-loader-contract.test.tsbun run checkshowAutoCaptureToasts: true, confirm a capture toast appears in the TUI (not only on server stdout)plugins: ["opencode-mem@…"]alone loads the companion (no second plugin entry needed)Closes #391