[codex] Preserve existing item position checks - #1001
Open
nexiumbiz-debug wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getNextPossiblePosition(existingItem)from moving an already valid dashboard item to the first open grid slotx/yFixes #907.
Root cause
getNextPossiblePositionsearches from the top-left of the grid and mutates the item object as it searches. When callers pass an item that already belongs to the rendered dashboard just to check for available space, the method can treat the item as a new placement candidate and rewrite its coordinates.Validation
npm run test-lib -- --watch=falsenpm run build-libnpx eslint projects/angular-gridster2/src/lib/tests/gridster.spec.tsnpx eslint projects/angular-gridster2/src/lib/gridster.ts projects/angular-gridster2/src/lib/tests/gridster.spec.ts(blocked by pre-existing upstreamgridster.tslint errors: component selector, prefer-for-of, no-inferrable-types, unused eslint-disable)git diff --check(only the repo's LF/CRLF warning)