[GitHub Bot] Generated python SDK - #168
Closed
mpragosa-te wants to merge 1 commit into
Closed
Conversation
mpragosa-te
requested review from
brumarqu-te,
goncarva-te,
jabrowne-te,
kevihan-te,
phpinhei-te,
rodrirod-te,
sfreitas-te and
stulowes-te
as code owners
July 28, 2026 15:43
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b300d0ccbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| from thousandeyes_sdk.event_detection.models.domain_event_grouping import DomainEventGrouping | ||
| from thousandeyes_sdk.event_detection.models.error import Error | ||
| from thousandeyes_sdk.event_detection.models.event import Event | ||
| from thousandeyes_sdk.event_detection.models.event_affected_agent_type import EventAffectedAgentType |
There was a problem hiding this comment.
When existing consumers upgrade, imports such as from thousandeyes_sdk.event_detection import CloudEnterpriseAgentType and from thousandeyes_sdk.event_detection.models.cloud_enterprise_agent_type import CloudEnterpriseAgentType now fail because this commit removes both the public export and module while replacing the enum with a compatible superset. Retain a deprecated alias/module for CloudEnterpriseAgentType so this API schema rename does not become an avoidable SDK-breaking change.
Useful? React with 👍 / 👎.
| end_date: Annotated[Optional[datetime], Field(description="Defaults to current time the request is made. Use with the `startDate` parameter. Include the complete time (hours, minutes, and seconds) in UTC time zone, following the ISO 8601 date-time format. See the example for reference. Please note that this parameter can't be used with `window`.")] = None, | ||
| max: Annotated[Optional[StrictInt], Field(description="(Optional) Maximum number of objects to return.")] = None, | ||
| cursor: Annotated[Optional[StrictStr], Field(description="(Optional) Opaque cursor used for pagination. Clients should use `next` value from `_links` instead of this parameter.")] = None, | ||
| ongoing: Annotated[Optional[StrictBool], Field(description="When set to `true`, only ongoing (active) events whose start date is within the specified time window are included in the response. When set to `false`, ongoing events are excluded from the response. If not set, both ongoing and concluded events appear in the response.")] = None, |
There was a problem hiding this comment.
When an existing caller passes _request_timeout or a later transport option positionally, inserting ongoing before those parameters changes the argument binding after upgrade; for example, a previously valid seventh argument of 30 is now validated as ongoing and raises a Pydantic boolean validation error instead of setting the timeout. Preserve the prior positional slots, such as by making the new option keyword-only, across get_events and its companion variants.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.