[GitHub Bot] Generated java SDK - #181
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: feec85e07f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| public Events getEvents(String aid, String window, OffsetDateTime startDate, OffsetDateTime endDate, Integer max, String cursor, Boolean ongoing) throws ApiException { | ||
| ApiResponse<Events> response = getEventsWithHttpInfo(aid, window, startDate, endDate, max, cursor, ongoing); |
There was a problem hiding this comment.
When an existing client upgrades this SDK, every call to the previous six-argument getEvents method now fails to compile, while replacing the JAR without recompiling produces NoSuchMethodError; the same break affects getEventsPaginated and getEventsWithHttpInfo. Since ongoing is optional, retain the prior public overloads and delegate them to these new signatures with null.
Useful? React with 👍 / 👎.
| public static final String JSON_PROPERTY_ASN = "asn"; | ||
| private Integer asn; |
There was a problem hiding this comment.
When an agent-branch event is associated with a valid 32-bit ASN above Integer.MAX_VALUE—notably a private-use ASN in the 4200000000–4294967294 range—Jackson cannot bind the response's numeric asn into this Integer, causing the entire event response to fail deserialization. Use Long, as the SDK's other network-provider ASN models do.
Useful? React with 👍 / 👎.
| public EventAffectedAgentType getType() { | ||
| return type; |
There was a problem hiding this comment.
When clients compiled against the previous SDK call EventApiAffectedAgent#getType, this changed return type alters the JVM method descriptor and causes NoSuchMethodError; recompiling also fails because CloudEnterpriseAgentType was deleted and the builder and setter now require a different enum. Preserve the existing enum type and add the new constants to it, or provide a compatible migration layer instead of replacing the public type.
Useful? React with 👍 / 👎.
2 participants
No description provided.