[GitHub Bot] Generated java SDK - #178
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54f99d83e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| */ | ||
| public Events getEvents(String aid, String window, OffsetDateTime startDate, OffsetDateTime endDate, Integer max, String cursor) throws ApiException { | ||
| ApiResponse<Events> response = getEventsWithHttpInfo(aid, window, startDate, endDate, max, cursor); | ||
| public Events getEvents(String aid, String window, OffsetDateTime startDate, OffsetDateTime endDate, Integer max, String cursor, Boolean ongoing) throws ApiException { |
There was a problem hiding this comment.
Adding the optional ongoing argument by replacing the existing methods removes the previously published JVM method descriptors for getEvents, getEventsWithHttpInfo, and getEventsPaginated. If a precompiled library or application built against 4.2.0 resolves this updated SDK transitively, calls to those methods fail at runtime with NoSuchMethodError; retain the old overloads and delegate them with ongoing == null while exposing the new overloads.
Useful? React with 👍 / 👎.
| @JsonInclude(value = JsonInclude.Include.USE_DEFAULTS) | ||
|
|
||
| public CloudEnterpriseAgentType getType() { | ||
| public EventAffectedAgentType getType() { |
There was a problem hiding this comment.
Changing getType() and setType() from CloudEnterpriseAgentType to EventAffectedAgentType while deleting the former class breaks the published binary API. A precompiled consumer that invokes the old getter or setter against this SDK receives NoSuchMethodError because the enum type is part of the JVM method descriptor; keep the existing enum type (expanding it with the new values if needed) or otherwise provide a binary-compatible migration path.
Useful? React with 👍 / 👎.
2 participants
No description provided.